Support github action changes?

[wei18]

Set fetch-depth: 1 when using https://github.com/actions/checkout to checkout a branch.

It's difficult to get changes from the local Git history.

It would be helpful to have a flag --github-action to fetch changes from the remote, like in the example below:

const { data: changedFiles } = await github.rest.pulls.listFiles({
  owner: context.repo.owner,
  repo: context.repo.repo,
  pull_number: context.issue.number
});

[mikeger]

Hey @wei18 ,

thanks for the observation, indeed, on some CIs it's hard to calculate the changeset since the repo checkout is shallow (depth 1).

However, adding GitHub API library as a dependency has some drawbacks. Would it be satisfactory to add a feature to receive the list of changed files as as command line argument, so the workflow would look in the following way:

• A script is fetching the changeset from GitHub
• Output of this script is forwarded as a command line argument to XcodeSelectiveTesting

What do you think?

[wei18]

LGTM.

[mikeger]

@wei18 can you check this version, would it work for you? #39

[wei18]

I was slightly delayed. I'll let you know once I've verified #39.

[mikeger]

I added the change to release 0.11.0

[wei18]

Verified, but found an issue with whitespace

mint run mikeger/XcodeSelectiveTesting@0.11.0 -c $(gh pr view 6112 --json files --jq '.files[].path' | sed 's/^/"/;s/$/"/')  --dependency-graph

Command Breakdown

mint run mikeger/XcodeSelectiveTesting@0.11.0

This runs the XcodeSelectiveTesting tool using Mint, which is a package manager for Swift command-line tools.
The specific version being used is 0.11.0.

-c (or --changed-files)

Specifies the list of files that have changed. This is required by XcodeSelectiveTesting to determine which tests to run based on the changes.

$(gh pr view 6112 --json files --jq '.files[].path' | sed 's/^/"/;s/$/"/')

This dynamically retrieves the changed files from Pull Request #6112 using the GitHub CLI (gh) and formats them properly:

gh pr view 6112 --json files --jq '.files[].path':

Fetches the list of changed file paths in PR #6112 in JSON format and extracts the file paths using jq.

| sed 's/^/"/;s/$/"/':

[wei18]

I found an issue with the log:

-c "Modules/App/App/CleanCode/Favlist/Favorites Tab/FavItem/FavItemListViewController.swift"

Changed file at /Users/Wei/Code/iOS/"Modules/App/App/CleanCode/Favlist/Favorite appears not to belong to any target
Changed file at /Users/Wei/Code/iOS/Tab/FavItem/FavItemListViewController.swift" appears not to belong to any target

[mikeger]

Interesting, let me investigate. I rely on https://github.com/apple/swift-argument-parser.git, I will check if updating it would solve the issue

[wei18]

If I manually pass file paths directly into the -c option, it works as expected, but when I dynamically generate the file paths using a command substitution, it fails.

PASS

mint run mikeger/XcodeSelectiveTesting@0.11.0 --dependency-graph -c "A/AppDelegate.swift" "A/CheckoutNavigator.swift" "A/ScreenViewController.swift" 

FAIL

test=$(gh pr view 6112 --json files --jq '.files[].path' | sed 's/^/"/;s/$/"/')
mint run mikeger/XcodeSelectiveTesting@0.11.0 --dependency-graph -c $(echo $test)

FAIL

mint run mikeger/XcodeSelectiveTesting@0.11.0 --dependency-graph -c $(gh pr view 6112 --json files --jq '.files[].path' | sed 's/^/"/;s/$/"/')

[wei18]

Finally, it works:

test=$(gh pr view 6112 --json files --jq '.files[].path' | sed 's/^/"/;s/$/"/' | tr '\n' ' ')
eval mint run mikeger/XcodeSelectiveTesting@0.11.0 --dependency-graph -c $test

Explanation:
tr '\n' ' ': Replaces newlines with spaces, so the paths are passed as a single string with spaces separating them.
eval: Evaluates the command as a whole and correctly passes the file paths to the -c option.

[mikeger]

Thanks, this makes sense. Glad it worked for you