__DEV__ mode doesn't initialize trackJs

[junseld]

Hey,
you wrote that you did that because there is too much noise in dev builds.
But when you use e.g. trackJs.track(...) in your code, it should fail because trackJs is not defined.
Do you always have null/undefined checks whenever you do that?

can't we just set config.enabled = false (or leave it to the developer to do that)?
or can you add an additional parameter that can bypass that if (__DEV__) check?

e.g.
function init(config, forceInit) { if (__DEV__ && !forceInit) { return; } ... }

Thanks,
and sorry if you are to busy with other stuff and don't want to invest any time in this.

[mikelambert]

Ahh sorry, I only use trackjs for crash reporting, and so do not use/call trackjs.track.

I didn't realize config.enabled works. If you want to make config.enabled = __DEV__, I'd definitely be open to that change.

(Though probably do it only if config.enabled is not explicitly set by the caller, to make it backwards compatible behavior-wise.)

[junseld]

oh yeah thought you wouldn't use that or have some nice solution I could copy ;)

so something like this? altough I don't know since when trackjs supports config.enabled (so older versions of trackjs would ignore that)
if (typeof config.enabled === 'undefined') { config.enabled = !__DEV__ }
instead of if (__DEV__) return;

[mikelambert]

LGTM (looks good to me)

Care to submit a pull request?

[junseld]

ok

[junseld]

Nice, thanks. Can you also publish that on npm?