From 6cc00a51b69f8ba0f0166d1cf48ac9ae9c4c6639 Mon Sep 17 00:00:00 2001 From: DeliveryService <64985255+sandipratamaputra@users.noreply.github.com> Date: Sat, 6 Jun 2020 19:45:24 +0700 Subject: [PATCH] Fixed language structure for names and place's names in the interface Addressing issue #1641 also added in a localization suggestion for the structure. Needs Review. --- collective_builder.cpp | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/collective_builder.cpp b/collective_builder.cpp index da4a0a7f7..2c3a10b27 100644 --- a/collective_builder.cpp +++ b/collective_builder.cpp @@ -70,15 +70,36 @@ optional CollectiveBuilder::generateName() const { auto leader = creatures[0].creature; ret.viewId = leader->getViewObject().id(); if (locationName && raceName) - ret.full = capitalFirst(*raceName) + " of " + *locationName; + ret.full = " The " + capitalFirst(*raceName) + " of " + capitalFirst(*locationName); + // ========================================================= + // When Localization project is on progress, perhaps consider using this format + // after making an identifier function for these section. + // The usage is for anything with connector (of, and, from, etc). + // Example 1: + // File directory: /mod/localization/Japanese/JPN_LOC.txt + // (resource file name can be arbitrary, used for debugging address, + // the real that matters is the previous folder's name) + // ========================== + // #/mod/localization/Japanese/JPN_LOC.txt (Arbitrary section used for debugging) + // { locationName&&RaceName = locationName + "の" + raceName } + // Example 2: + // File directory: /mod/localization/Indonesian/INA_LOC.txt + // (file name can be arbitrary, used for debugging address, + // the real that matters is the previous folder's name) + // ========================== + // #/mod/localization/Japanese/INA_LOC.txt (Arbitrary section used for debugging) + // { locationName&&RaceName = raceName locationName } + // ========================================================= + // DeliveryService + // ========================================================= else if (!!leader->getName().first()) ret.full = leader->getName().title(); else if (raceName) - ret.full = capitalFirst(*raceName); + ret.full = "The " + capitalFirst(*raceName); else ret.full = leader->getName().title(); if (locationName) - ret.shortened = *locationName; + ret.shortened = "The " + capitalFirst(*locationName); else if (auto leaderName = leader->getName().first()) ret.shortened = *leaderName; if (raceName)