inlineing fixes

Author: KaQuMiQ

Futura.xcodeproj/project.pbxproj

@@ -823,11 +823,12 @@
 				ONLY_ACTIVE_ARCH = YES;
 				OTHER_SWIFT_FLAGS = "-DXcode";
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SDKROOT = macosx;
+				SDKROOT = "";
 				SUPPORTED_PLATFORMS = "macosx iphoneos iphonesimulator appletvos appletvsimulator watchos watchsimulator";
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) SWIFT_PACKAGE DEBUG FUTURA_DEBUG";
 				SWIFT_OPTIMIZATION_LEVEL = "-Onone";
 				USE_HEADERMAP = NO;
+				VALID_ARCHS = "$(VALID_ARCHS)";
 			};
 			name = Debug;
 		};
@@ -847,11 +848,12 @@
 				MACOSX_DEPLOYMENT_TARGET = 10.12;
 				OTHER_SWIFT_FLAGS = "-DXcode";
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SDKROOT = macosx;
+				SDKROOT = "";
 				SUPPORTED_PLATFORMS = "macosx iphoneos iphonesimulator appletvos appletvsimulator watchos watchsimulator";
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) SWIFT_PACKAGE";
 				SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
 				USE_HEADERMAP = NO;
+				VALID_ARCHS = "$(VALID_ARCHS)";
 			};
 			name = Release;
 		};
@@ -880,7 +882,6 @@
 				SWIFT_VERSION = 5.0;
 				TARGET_NAME = Futura;
 				TVOS_DEPLOYMENT_TARGET = 10.0;
-				VALID_ARCHS = "arm64 arm64e armv7 armv7s x86_64 i386";
 				WATCHOS_DEPLOYMENT_TARGET = 4.0;
 			};
 			name = Debug;
@@ -910,7 +911,6 @@
 				SWIFT_VERSION = 5.0;
 				TARGET_NAME = Futura;
 				TVOS_DEPLOYMENT_TARGET = 10.0;
-				VALID_ARCHS = "arm64 arm64e armv7 armv7s x86_64 i386";
 				WATCHOS_DEPLOYMENT_TARGET = 4.0;
 			};
 			name = Release;

Futura.xcodeproj/xcshareddata/xcschemes/Futura.xcscheme

@@ -56,6 +56,7 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      enableThreadSanitizer = "YES"
       launchStyle = "0"
       useCustomWorkingDirectory = "NO"
       ignoresPersistentStateOnLaunch = "NO"

Futura.xcodeproj/xcshareddata/xcschemes/FuturaTest.xcscheme

@@ -30,7 +30,7 @@
       shouldUseLaunchSchemeArgsEnv = "YES">
       <Testables>
          <TestableReference
-            skipped = "NO">
+            skipped = "YES">
             <BuildableReference
                BuildableIdentifier = "primary"
                BlueprintIdentifier = "Futura::FuturaPerformanceTests"
@@ -66,6 +66,7 @@
       buildConfiguration = "Debug"
       selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
       selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
+      enableThreadSanitizer = "YES"
       launchStyle = "0"
       useCustomWorkingDirectory = "NO"
       ignoresPersistentStateOnLaunch = "NO"

Sources/Futura/Atomic/AtomicFlag.swift

@@ -22,15 +22,15 @@ public enum AtomicFlag {
     /// Atomic flag is initialized not set (false)
     ///
     /// - Returns: Pointer to new ataomic flag instance
-    @inline(__always)
+    @inlinable
     public static func make() -> Pointer {
         let pointer = Pointer.allocate(capacity: 1)
         pointer.pointee = atomic_flag()
         return pointer
     }
 
     /// - Parameter pointer: Pointer to flag to be destroyed.
-    @inline(__always)
+    @inlinable
     public static func destroy(_ pointer: Pointer) {
         pointer.deinitialize(count: 1)
         pointer.deallocate()
@@ -39,15 +39,15 @@ public enum AtomicFlag {
     /// Reads current value of flag and sets it to true
     ///
     /// - Parameter pointer: Pointer to flag to be read and set.
-    @discardableResult @inline(__always)
+    @discardableResult @inlinable
     public static func readAndSet(_ pointer: Pointer) -> Bool {
         return atomic_flag_test_and_set(pointer)
     }
 
     /// Clears flag (set to false)
     ///
      /// - Parameter pointer: Pointer to flag to be cleared.
-    @inline(__always)
+    @inlinable
     public static func clear(_ pointer: Pointer) {
         atomic_flag_clear(pointer)
     }

Sources/Futura/Synchronization/Mutex.swift

@@ -19,17 +19,24 @@ import Darwin.POSIX
 #endif
 
 #if os(Linux)
+@usableFromInline
 fileprivate let nSecMsec: __time_t = 1_000_000
+@usableFromInline
 fileprivate let mSecSec: __time_t = 1_000 * nSecMsec
 #else
-fileprivate let nSecMsec: __darwin_time_t = 1_000_000
-fileprivate let mSecSec: __darwin_time_t = 1_000 * nSecMsec
+@usableFromInline
+internal let nSecMsec: __darwin_time_t = 1_000_000
+@usableFromInline
+internal let mSecSec: __darwin_time_t = 1_000 * nSecMsec
 #endif
 
 /// pthread_mutex api wrapper
 public enum Mutex {
     /// Error thrown on mutex timeout
-    public struct Timeout: Error {}
+    public struct Timeout: Error {
+        @usableFromInline
+        internal init(){}
+    }
 
     /// pthread_mutex_t pointer type
     public typealias Pointer = UnsafeMutablePointer<pthread_mutex_t>
@@ -40,7 +47,7 @@ public enum Mutex {
     ///
     /// - Parameter recursive: Tells if created mutex should be recursive or not.
     /// - Returns: Pointer to new mutex instance
-    @inline(__always)
+    @inlinable
     public static func make(recursive: Bool) -> Pointer {
         let pointer: UnsafeMutablePointer<pthread_mutex_t> = .allocate(capacity: 1)
         let attr: UnsafeMutablePointer<pthread_mutexattr_t> = .allocate(capacity: 1)
@@ -57,7 +64,7 @@ public enum Mutex {
     /// Deallocates instance of pthread_mutex
     ///
     /// - Parameter pointer: Pointer to mutex to be destroyed.
-    @inline(__always)
+    @inlinable
     public static func destroy(_ pointer: Pointer) {
         pthread_mutex_destroy(pointer)
         pointer.deinitialize(count: 1)
@@ -67,7 +74,7 @@ public enum Mutex {
     /// Locks on instance of pthread_mutex or waits until unlocked if locked.
     ///
     /// - Parameter pointer: Pointer to mutex to be locked.
-    @inline(__always)
+    @inlinable
     public static func lock(_ pointer: Pointer) {
         pthread_mutex_lock(pointer)
     }
@@ -77,7 +84,7 @@ public enum Mutex {
     ///
     /// - Parameter pointer: Pointer to mutex to be locked.
     /// - Parameter timeout: Lock wait timeout in seconds.
-    @inline(__always)
+    @inlinable
     public static func lock(_ pointer: Pointer, timeout: UInt8) throws -> Void {
         #if os(Linux)
         var currentTimeout = __time_t(timeout) * mSecSec
@@ -104,15 +111,15 @@ public enum Mutex {
     ///
     /// - Parameter pointer: Pointer to mutex to be locked.
     /// - Returns: Result of trying to lock. True if succeeded, false otherwise.
-    @inline(__always)
+    @inlinable
     public static func tryLock(_ pointer: Pointer) -> Bool {
         return pthread_mutex_trylock(pointer) == 0
     }
 
     /// Unlocks on instance of pthread_mutex
     ///
     /// - Parameter pointer: Pointer to mutex to be unlocked.
-    @inline(__always)
+    @inlinable
     public static func unlock(_ pointer: Pointer) {
         pthread_mutex_unlock(pointer)
     }

Sources/Futura/Synchronization/RecursiveLock.swift

@@ -16,10 +16,8 @@
 /// It should not be used to synchronize threads from multiple processes.
 public final class RecursiveLock {
 
-    /// Reference to underlying mutex.
-    /// Should not be used - public only for optimizations.
-    /// All operations on mutex should be performed via public interface of Lock.
-    public let mtx: Mutex.Pointer = Mutex.make(recursive: true)
+    @usableFromInline
+    internal let mtx: Mutex.Pointer = Mutex.make(recursive: true)
 
     /// Creates instance of recursive lock.
     public init() {}
@@ -30,7 +28,7 @@ public final class RecursiveLock {
 
     /// Locks if possible or waits until unlocked.
     /// Since RecursiveLock is recursive it will continue when already locked on same thread.
-    @inline(__always)
+    @inlinable
     public func lock() {
         Mutex.lock(mtx)
     }
@@ -39,28 +37,28 @@ public final class RecursiveLock {
     /// Throws an error if time condition was not met
     ///
     /// - Parameter timeout: Lock wait timeout in seconds.
-    @inline(__always)
+    @inlinable
     public func lock(timeout: UInt8) throws -> Void {
         try Mutex.lock(mtx, timeout: timeout)
     }
 
     /// Locks if possible and returns true or returns false otherwise without locking.
     /// Since RecursiveLock is recursive it will returns true when already locked on same thread.
-    @inline(__always)
+    @inlinable
     public func tryLock() -> Bool {
         return Mutex.tryLock(mtx)
     }
 
     /// Unlocks a lock.
-    @inline(__always)
+    @inlinable
     public func unlock() {
         Mutex.unlock(mtx)
     }
 
     /// Execute closure with synchronization on self as lock.
     /// Since RecursiveLock is recursive you can call synchronized recursively on same thread.
     /// It will wait until unlocked if locked when calling.
-    @inline(__always)
+    @inlinable
     public func synchronized<T>(_ block: () throws -> T) rethrows -> T {
         Mutex.lock(mtx)
         defer { Mutex.unlock(mtx) }

Sources/Futura/Worker/DispatchQueueWorker.swift

@@ -16,6 +16,7 @@ import Dispatch
 
 extension DispatchQueue: Worker {
     /// OperationQueue as Worker assigns work to queue using async method.
+    @inlinable
     public func schedule(_ work: @escaping () -> Void) {
         async(execute: work)
     }

Sources/Futura/Worker/ExecutionContext.swift

@@ -25,7 +25,7 @@ public enum ExecutionContext {
 }
 
 internal extension ExecutionContext {
-    @inline(__always)
+    @inlinable
     func execute(_ function: @escaping () -> Void) {
         switch self {
             case .undefined:

Sources/Futura/Worker/OperationQueueWorker.swift

@@ -17,6 +17,7 @@ import Foundation
 extension OperationQueue: Worker {
     /// OperationQueue as Worker assigns work to queue using addOperation method
     /// or executes it immediately if detects it is already on that queue.
+    @inlinable
     public func schedule(_ work: @escaping () -> Void) {
         if OperationQueue.current == self {
             work()