You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Allows setting a custom ExifTool config file.
Because the -config option has to be the first one specified, it required modifying the strategies directly.
The optimal solution would have been to add configPath as a parameter for execute() just like whats done for the ExifTool path, but that would have broken backwards compatibility, so instead I added a setConfigFilePath() method to ExecutionStrategy.
Because the strategies always add -sep before the given arguments and -config must be the first option.
And it cant add that after since then it would be after -execute.
I guess each strategy could manually insert -sep in between the arguments, but that would be worse IMO.
It might be better to make ExifTool.toArguments add -sep instead,
BUT to keep backwards compatibility getRawExifToolOutput would have to be modified to add -sep to the argument list,
which would in turn break compatibility for programs that subclass ExecutionStrategy, make it not add -sep, and use getRawExifToolOutput, expecting it to not have -sep as an argument.
Also it would be a compatibility breakage for every ExecutionStrategy subclass since they would now get an unexpected -sep argument, but that might not be as big of a deal as AFAIK duplicate -sep arguments get ignored.
Honestly the whole api is very inconsistent (like #205), but sadly it cant be cleaned up without a compatibility breakage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting a custom ExifTool config file.
Because the
-configoption has to be the first one specified, it required modifying the strategies directly.The optimal solution would have been to add
configPathas a parameter forexecute()just like whats done for the ExifTool path, but that would have broken backwards compatibility, so instead I added asetConfigFilePath()method toExecutionStrategy.Closes #247