[Angular] Extract Function not detected

[mkshiblu]

Commit: github.com/angular/angular.js/commit/42e622b751d1ad1520b824473f9ad31e7efb75b3
File: src/ng/compile.js (line ~2793)
Original Method: nodeLinkFn
ExtractedMethod: setupControllers

Repository	Commit	Refactoring	Node type	Location before	Local name before	Location after	Local name after
angular.js	42e622b751d1ad1520b824473f9ad31e7efb75b3	EXTRACT_MOVE	Function	src/ng/compile.js:124567-132721	nodeLinkFn	src/ng/compile.js:133977-135217	setupControllers

JSRMiner IS reporting a rename variable

Rename Variable directive to controllerDirective in $CompileProvider.10.applyDirectivesToNode.nodeLinkFn(childLinkFn ,scope ,linkNode ,$rootElement ,boundTranscludeFn) at src/ng/compile.js|$CompileProvider.10.applyDirectivesToNode.nodeLinkFn

[mkshiblu]

@tsantalis Can you please take a look whenever you get a chance and let me know your thoughts on these two instances? (e.g. ExtractMove or Extract only) Specifically, is the rename variable a True Positive?

[tsantalis]

The commit is not accessible. I get "404 not found"
But it looks like an Extract Function.

The rename variable is not correct. because directive declaration is matched in the extracted method.
name is renamed to controllerKey in the extracted method.

[mkshiblu]

@tsantalis Thanks for your reply. Looks like GitHub automatllcally shortened the visible URL. The updated link should work now.

I agree that the renamed variable is FN and Instead of ExtractMoveFunction it is an ExtractFunction refactoring.

[mkshiblu]

Commit: github.com/angular/angular.js/commit/8e104ee508418bc2ebb65e5b4ac73d22285cc224

File: src/ng/compile.js (line ~2793)

Extract Method Missed By both tool-

Original Method: nodeLinkFn
ExtractedMethod: setupControllers

Interestingly, though the same refactorings have been performed same as in the commit in description, in this commit it's not being reported by any of the tools.