From 527d18cc9fcf3cfd7491b47a99bd24d8506ba6db Mon Sep 17 00:00:00 2001 From: LongYinan Date: Sat, 21 Mar 2026 17:45:12 +0800 Subject: [PATCH] Fix depthwise conv 1D kernel name for large variant The kernel name was constructed with the wrong argument order, producing `depthwise_conv_1d__largefloat16` instead of `depthwise_conv_1d_float16_large` which matches the Metal kernel registration. --- mlx/backend/metal/conv.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mlx/backend/metal/conv.cpp b/mlx/backend/metal/conv.cpp index 3c6b84ca31..fac135fe18 100644 --- a/mlx/backend/metal/conv.cpp +++ b/mlx/backend/metal/conv.cpp @@ -1041,8 +1041,8 @@ void depthwise_conv_1D_gpu( concatenate( base_name, "depthwise_conv_1d_", - large ? "_large" : "", - type_to_name(out)); + type_to_name(out), + large ? "_large" : ""); auto& compute_encoder = d.get_command_encoder(s.index); auto kernel = d.get_kernel(base_name);