Skip to content

Fix bfloat16 not recognized as floating point dtype #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfalbel merged 2 commits into from
Feb 2, 2026
+35 −3
Merged

Fix bfloat16 not recognized as floating point dtype #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8241faf
Fix bfloat16 not recognized as floating point dtype
dfalbel Feb 2, 2026
2f54fbb
Add test for module$to with bfloat16 dtype
dfalbel Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/dtype.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ torch_dtype <- R7Class(
),
active = list(
is_floating_point = function() {
if (cpp_dtype_to_string(self$ptr) %in% c("Float", "Double", "Half")) {
if (cpp_dtype_to_string(self$ptr) %in% c("Float", "Double", "Half", "BFloat16")) {
TRUE
} else {
FALSE
Expand Down
28 changes: 26 additions & 2 deletions tests/testthat/test-dtype.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,34 @@ test_that("can set select devices using strings", {
})

test_that("error when comparing dtypes", {

expect_error(
NULL == torch_float64(),
"not a dtype"
)


})

test_that("is_floating_point works for all floating point types", {
# All standard floating point types should return TRUE

expect_true(torch_float()$is_floating_point)
expect_true(torch_float32()$is_floating_point)
expect_true(torch_float64()$is_floating_point)
expect_true(torch_double()$is_floating_point)
expect_true(torch_float16()$is_floating_point)
expect_true(torch_half()$is_floating_point)

expect_true(torch_bfloat16()$is_floating_point)

# Non-floating point types should return FALSE
expect_false(torch_int()$is_floating_point)
expect_false(torch_int32()$is_floating_point)
expect_false(torch_int64()$is_floating_point)
expect_false(torch_long()$is_floating_point)
expect_false(torch_int16()$is_floating_point)
expect_false(torch_short()$is_floating_point)
expect_false(torch_int8()$is_floating_point)
expect_false(torch_uint8()$is_floating_point)
expect_false(torch_bool()$is_floating_point)
})
8 changes: 8 additions & 0 deletions tests/testthat/test-nn.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,14 @@ test_that("to", {
expect_equal(net$linear$bias$device$type, "cpu")
})

test_that("module$to works with bfloat16", {
net <- nn_linear(10, 10)
net$to(dtype = torch_bfloat16())

expect_true(net$weight$dtype == torch_bfloat16())
expect_true(net$bias$dtype == torch_bfloat16())
})

test_that("state_dict for modules", {
Net <- nn_module(
initialize = function() {
Expand Down
Loading