fixed recovery of metric depth for orthographic cameras #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This indeed fixes the issues with incorrect depth values when using orthographic cameras. |
|
this fixes orthographic depth bug @mmatl i see you have branch https://github.com/mmatl/pyrender/commits/depth_linearization |
maxbarnikol
added a commit
to maxbarnikol/pyrender
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the dissection of the opengl camera matrix I fixed what I think is a bug in the recovery of the metric depth for orthographic cameras.
Please let me know if there are any changes or test you would like to be added to the PR.