-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Implement data skip in samples #13270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Do you have or could you create some tiny test file that has this attribute that we could add to mne-testing-data? |
|
I will do that. Would a variant of intervalrecording_raw.fif be OK (at 12MB not sure it can be considered as tiny) ? If it is, I already have it, it will just remain to write the test down. Otherwise, I need to create a smaller one which would require a bit more time (but normally it shouldn't be too difficult). |
|
Ideally < 1 MB would be better so if you can shrink it please do! |
|
OK. Will do. |
|
@papadop just a friendly ping about this one in case you have time to come back to it! |
|
Thanks for the reminder. I'll try to do it in the coming days. |
Reference issue (if any)
None
What does this implement/fix?
This implements the handling of the tag FIFF_DATA_SKIP_SAMP.
It does it by adding the handling of the tag in the reading loop.
Also, the implementation of the initial data skip is changed by leveraging the in-loop reading code instead of duplicating it as it was. In addition, the new code should handle correctly multiple FIFF_DATA_SKIP_SAMP or FIFF_DATA_SKIP, which was not the case previsouly.
Additional information
Fiff documentation states:
This patch does it.
This is not a feature used that often, but since it is documented that way....