Make _ForwardModeler fill out the complete forward object #13416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmvanvliet
commented
Sep 11, 2025
| limit=self.mindist, | ||
| mri_head_t=self.mri_head_t, | ||
| src=src, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
this is a refactor that makes sense to me.
Member
There was a problem hiding this comment.
Yeah I think that was just cruft from when I was working on it and there were two code paths 🤦
wmvanvliet
commented
Sep 11, 2025
larsoner
approved these changes
Sep 11, 2025
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Just going to push a commit to fix pip-pre, thanks in advance @wmvanvliet !
| limit=self.mindist, | ||
| mri_head_t=self.mri_head_t, | ||
| src=src, | ||
| ) |
Member
There was a problem hiding this comment.
Yeah I think that was just cruft from when I was working on it and there were two code paths 🤦
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@larsoner Small bug that came alight when using #13407 for dipole fitting: some fields were left blank that shouldn't be. This PR fixes those and updates the unit test to check them.