No issue, just help

[jonobg]

Hi, I’m interested in contributing. Is there any area where you’d like extra help?

I'll make a fork and start improving, then I can tag you later and show what I've done.

[mnh-jansson]

Moved over to discussion.

Any help is welcome.

What we are still missing is a way to decipher the serial number written on the case and a few registers that are either static or unknown. It would be really helpful to get more data so we can better compare information on the label with the data we see in the registers. We have a function in the script that submits the data into a google form.

[mnh-jansson]

Maybe you can let the AI loose on the open-battery-information repo instead, and if it makes sense we continue from there? Not very keen on starting yet another project repo for essentially the same purpose.

[jonobg]

Maybe you've seen that I've included things from all of you repos, so could we just copy it to your open-battery-information repo, because it should (if everything is working as it supposed) have all features of what you've done.

I just put it in my GitHub repo now so that you could get a view of what I'm doing. The naming was done by the AI, so you can rename it so it will fit in your repo.

Or, is it okay to use your repo "open-battery-information" but then add the UBD framework (or whatever the AI called it) to your repo in a new branch?

[jonobg]

I don't really want to have, what I've done, on my GitHub account. But now, the AI rebuilt pretty much everything. However, it's based of your code, so it wouldn't have been able to do it without what was written. Please get me right, I don't want to step in an say anything, because I've done almost nothing to this project compared to you, so it's completely up to you how to proceed.

[mnh-jansson]

Yes i saw. I would remove the nec78k0 tool as this is not really relevant, also Dewalt will never be supported as they dont have communication. In my opinion it's a bit too ambitious so i would scale it down alittle but other than that i see no problem with it if it simplifies the structure and helps contributions.

If you can port it as a pull request to open-battery-information i can take a look. And of course, 1000 lines of pretty code is nice and all but does not matter if it does not work 😄

[jonobg]

I agree. It would need testing,

Okay, I can rewrite it, strip unnecessary parts and port it. I might not have time today, but I'll do it, maybe tomorrow.

If you have other suggestions, please write them down and I'll make the changes! :)

[Its-donkey]

@mnh-jansson do you have data dumps you'd be happy to share? None of my batteries are new enough to have any diagnostics, so I am unable to try and assist with the analysis but would like to help if I may.

[DarthTaters]

I can send you some dumps if that'll help. Not sure how to get them to you but we can sort that out if you're still interested.

[Its-donkey]

That would be great. You could upload them to a repository if you're not concerned about them being public