Skip to content

Refactoring suggestions for inline class failed to consider inheritance #2

@moar82

Description

@moar82

Description

When SAD detects lazy class, RefGen proposes to inline the class to the class that makes use of it. However, there are some cases where the classes do not implement any method, but extend a parent class with the functionality used in the target class to inline the supposedly "lazy class" (source class). This is a case of false positive that could be fixed directly in SAD from PtiDej, (a.k.a, DECOR). From the refactoring suggestion engine (a.k.a, SACO) it could be validated if source class extends another class do not propose the refactoring.

###Affects
Eclipse Plug-in, Simulation mode (command line), SAD (PtiDej)

###Reproducibility
at-robotsj, forked from sourceforge in my github account.
Check the following commit moar82/at-robots@522a07e the refactored was applied using RefGen, broken the build.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions