Skip to content

Commit 40e6405

Browse files
committed
un-skip tests on Windows V19H1 (1903) and up
This re-enables TestChangesDirsEmpty and TestChangesDirsMutated on current Windows versions. These tests were failing on Windows V19H1 (1903) and up, possibly due to changes in the kernel, and were skipped in commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f; === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsEmpty (0.21s) changes_test.go:261: Reported changes for identical dirs: [{\dirSymlink C}] === FAIL: github.com/docker/docker/pkg/archive TestChangesDirsMutated (0.14s) changes_test.go:391: unexpected change "C \\dirSymlink" "\\dirnew" This reverts commit 8f4b3b0ad41a5e3a29e57f0a8c55cb49e7a0b44f. This reverts commit 3108165c94bf48014aa9f412193fe25852f1958f Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 5504b63 commit 40e6405

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

changes_test.go

-8
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,6 @@ func TestChangesWithChangesGH13590(t *testing.T) {
245245

246246
// Create a directory, copy it, make sure we report no changes between the two
247247
func TestChangesDirsEmpty(t *testing.T) {
248-
if runtime.GOOS == "windows" {
249-
t.Skip("FIXME: broken on Windows 1903 and up; see https://github.com/moby/moby/pull/39846")
250-
}
251-
252248
src, err := os.MkdirTemp("", "docker-changes-test")
253249
assert.NilError(t, err)
254250
defer os.RemoveAll(src)
@@ -331,10 +327,6 @@ func mutateSampleDir(t *testing.T, root string) {
331327
}
332328

333329
func TestChangesDirsMutated(t *testing.T) {
334-
if runtime.GOOS == "windows" {
335-
t.Skip("FIXME: broken on Windows 1903 and up; see https://github.com/moby/moby/pull/39846")
336-
}
337-
338330
src, err := os.MkdirTemp("", "docker-changes-test")
339331
assert.NilError(t, err)
340332
createSampleDir(t, src)

0 commit comments

Comments
 (0)