diff --git a/client/src/utils/__tests__/schemaUtils.test.ts b/client/src/utils/__tests__/schemaUtils.test.ts index 0ecd8075a..0e832b098 100644 --- a/client/src/utils/__tests__/schemaUtils.test.ts +++ b/client/src/utils/__tests__/schemaUtils.test.ts @@ -39,12 +39,12 @@ describe("generateDefaultValue", () => { ).toBe(false); }); - test("generates default array", () => { - expect(generateDefaultValue({ type: "array" })).toEqual([]); + test("generates undefined for optional array", () => { + expect(generateDefaultValue({ type: "array" })).toBe(undefined); }); - test("generates default empty object", () => { - expect(generateDefaultValue({ type: "object" })).toEqual({}); + test("generates undefined for optional object", () => { + expect(generateDefaultValue({ type: "object" })).toBe(undefined); }); test("generates default null for unknown types", () => { @@ -52,12 +52,32 @@ describe("generateDefaultValue", () => { expect(generateDefaultValue({ type: "unknown" })).toBe(undefined); }); - test("generates empty array for non-required array", () => { - expect(generateDefaultValue({ type: "array" })).toEqual([]); + test("generates empty array for required array", () => { + const parentSchema = { required: ["testArray"] }; + expect( + generateDefaultValue({ type: "array" }, "testArray", parentSchema), + ).toEqual([]); + }); + + test("generates undefined for non-required array", () => { + const parentSchema = { required: ["otherField"] }; + expect( + generateDefaultValue({ type: "array" }, "testArray", parentSchema), + ).toBe(undefined); }); - test("generates empty object for non-required object", () => { - expect(generateDefaultValue({ type: "object" })).toEqual({}); + test("generates empty object for required object", () => { + const parentSchema = { required: ["testObject"] }; + expect( + generateDefaultValue({ type: "object" }, "testObject", parentSchema), + ).toEqual({}); + }); + + test("generates undefined for non-required object", () => { + const parentSchema = { required: ["otherField"] }; + expect( + generateDefaultValue({ type: "object" }, "testObject", parentSchema), + ).toBe(undefined); }); test("generates undefined for non-required primitive types", () => { diff --git a/client/src/utils/schemaUtils.ts b/client/src/utils/schemaUtils.ts index 7a1751425..4ad8e8cab 100644 --- a/client/src/utils/schemaUtils.ts +++ b/client/src/utils/schemaUtils.ts @@ -109,9 +109,9 @@ export function generateDefaultValue( case "boolean": return isRequired ? false : undefined; case "array": - return []; + return isRequired ? [] : undefined; case "object": { - if (!schema.properties) return {}; + if (!schema.properties) return isRequired ? {} : undefined; const obj: JsonObject = {}; // Only include properties that are required according to the schema's required array @@ -123,7 +123,7 @@ export function generateDefaultValue( } } }); - return obj; + return isRequired ? obj : Object.keys(obj).length > 0 ? obj : undefined; } case "null": return null;