simplified struct Verification

Author: TomSaw

src/modm/driver/motion/adns9800.hpp

@@ -158,21 +158,21 @@ class Adns9800 : public adns9800, public modm::SpiDevice<SpiMaster> {
     /// @endcond
   };
 
-  union VerificationResult {
-    uint8_t value;
-    struct {
-      bool ProductId: 1;
-      bool ProductIdInverse: 1;
-      bool RevisionId: 1;
-    };
-    static constexpr uint8_t Ok = 0b111;
+  struct Verification {
+    bool ProductId: 1;
+    bool ProductIdInverse: 1;
+    bool RevisionId: 1;
+
+    operator bool() const {
+      return ProductId and ProductIdInverse and RevisionId;
+    }
   };
 
   void
   initialize() {
     powerUp();
-    const VerificationResult result = verifyIdentity();
-    if(result.value == VerificationResult::Ok) {
+
+    if(verify()) {
       writeFirmware();
       laserEnable();
     }
@@ -201,12 +201,12 @@ class Adns9800 : public adns9800, public modm::SpiDevice<SpiMaster> {
   /**
    * @brief     Verify presence of the device by validating various id registers.
    */
-  VerificationResult
-  verifyIdentity() {
-    return VerificationResult{
-      ProductId: readRegister(Register::Product_ID) == uint8_t(0x33),
-      ProductIdInverse: readRegister(Register::Inverse_Product_ID) == uint8_t(~0x33),
-      RevisionId: readRegister(Register::Revision_ID) == uint8_t(0x03)
+  Verification
+  verify() {
+    return {
+      ProductId: readRegister(Register::Product_ID) == static_cast<uint8_t>(0x33),
+      ProductIdInverse: readRegister(Register::Inverse_Product_ID) == static_cast<uint8_t>(~0x33),
+      RevisionId: readRegister(Register::Revision_ID) == static_cast<uint8_t>(0x03)
     };
   }