Bug: The atlas user create was calling the wrong endpoint (#234)

Author: andreaangiolillo

mongodbatlas/atlas_users.go

@@ -21,7 +21,8 @@ import (
 )
 
 const (
-	usersBasePath = "api/atlas/v1.0/groups/%s/users"
+	usersGroupBasePath = "api/atlas/v1.0/groups/%s/users"
+	usersBasePath      = "api/atlas/v1.0/users"
 )
 
 // AtlasUsersService is an interface for interfacing with the AtlasUsers
@@ -66,7 +67,7 @@ type AtlasUser struct {
 //
 // See more: https://docs.atlas.mongodb.com/reference/api/user-get-all/
 func (s *AtlasUsersServiceOp) List(ctx context.Context, orgID string, listOptions *ListOptions) ([]AtlasUser, *Response, error) {
-	path := fmt.Sprintf(usersBasePath, orgID)
+	path := fmt.Sprintf(usersGroupBasePath, orgID)
 
 	// Add query params from listOptions
 	path, err := setListOptions(path, listOptions)
@@ -100,7 +101,7 @@ func (s *AtlasUsersServiceOp) Get(ctx context.Context, userID string) (*AtlasUse
 		return nil, nil, NewArgError("userID", "must be set")
 	}
 
-	path := fmt.Sprintf("api/atlas/v1.0/users/%s", userID)
+	path := fmt.Sprintf("%s/%s", usersBasePath, userID)
 
 	req, err := s.Client.NewRequest(ctx, http.MethodGet, path, nil)
 	if err != nil {
@@ -124,7 +125,7 @@ func (s *AtlasUsersServiceOp) GetByName(ctx context.Context, username string) (*
 		return nil, nil, NewArgError("username", "must be set")
 	}
 
-	path := fmt.Sprintf("api/atlas/v1.0/users/byName/%s", username)
+	path := fmt.Sprintf("%s/byName/%s", usersBasePath, username)
 
 	req, err := s.Client.NewRequest(ctx, http.MethodGet, path, nil)
 	if err != nil {
@@ -148,7 +149,7 @@ func (s *AtlasUsersServiceOp) Create(ctx context.Context, createRequest *AtlasUs
 		return nil, nil, NewArgError("createRequest", "cannot be nil")
 	}
 
-	req, err := s.Client.NewRequest(ctx, http.MethodPost, "users", createRequest)
+	req, err := s.Client.NewRequest(ctx, http.MethodPost, usersBasePath, createRequest)
 	if err != nil {
 		return nil, nil, err
 	}

mongodbatlas/atlas_users_test.go

@@ -312,7 +312,7 @@ func TestAtlasUsers_Create(t *testing.T) {
 		Country: "US",
 	}
 
-	mux.HandleFunc("/users", func(w http.ResponseWriter, r *http.Request) {
+	mux.HandleFunc("/api/atlas/v1.0/users", func(w http.ResponseWriter, r *http.Request) {
 		expected := map[string]interface{}{
 			"username":     "john.doe@example.com",
 			"password":     "myPassword1@",