Small corrections-adjustements.

Author: papafe

src/MongoDB.Bson/IO/BsonWriterSettings.cs

@@ -14,7 +14,6 @@
 */
 
 using System;
-using MongoDB.Bson.Serialization;
 
 namespace MongoDB.Bson.IO
 {

src/MongoDB.Bson/Serialization/BsonDeserializationContext.cs

@@ -46,9 +46,6 @@ private BsonDeserializationContext(
 
             _serializationDomain = serializationDomain; //FP Using this version to find error in an easier way for now
             //_serializationDomain = serializationDomain ?? BsonSerializer.DefaultSerializationDomain;
-
-            _dynamicArraySerializer ??= _serializationDomain.BsonDefaults.DynamicArraySerializer;
-            _dynamicDocumentSerializer ??= _serializationDomain.BsonDefaults.DynamicDocumentSerializer;
         }
 
         // public properties
@@ -177,10 +174,11 @@ internal Builder(BsonDeserializationContext other, IBsonReader reader, IBsonSeri
                     _dynamicArraySerializer = other.DynamicArraySerializer;
                     _dynamicDocumentSerializer = other.DynamicDocumentSerializer;
                 }
-
-                /* QUESTION I removed the part where we set the dynamic serializers from the BsonDefaults, and delay it until we have a serialization domain (when we build the DeserializationContext).
-                 * This is technically changing the public behaviour, but it's in a builder, I do not thing it will affect anyone. Same done for the serialization context.
-                 */
+                else
+                {
+                    _dynamicArraySerializer = serializationDomain.BsonDefaults.DynamicArraySerializer;
+                    _dynamicDocumentSerializer = serializationDomain.BsonDefaults.DynamicDocumentSerializer;
+                }
             }
 
             // properties

src/MongoDB.Bson/Serialization/BsonSerializationInfo.cs

@@ -155,7 +155,7 @@ public BsonValue SerializeValue(object value)
             var tempDocument = new BsonDocument();
             using (var bsonWriter = new BsonDocumentWriter(tempDocument))
             {
-                //QUESTION Is it correct we only need a default domain here?
+                //QUESTION Is it correct we only need a standard domain here?
                 var context = BsonSerializationContext.CreateRoot(bsonWriter, BsonSerializer.DefaultSerializationDomain);
                 bsonWriter.WriteStartDocument();
                 bsonWriter.WriteName("value");
@@ -175,7 +175,7 @@ public BsonArray SerializeValues(IEnumerable values)
             var tempDocument = new BsonDocument();
             using (var bsonWriter = new BsonDocumentWriter(tempDocument))
             {
-                //QUESTION Is it correct we only need a default domain here?
+                //QUESTION Is it correct we only need a standard domain here?
                 var context = BsonSerializationContext.CreateRoot(bsonWriter, BsonSerializer.DefaultSerializationDomain);
                 bsonWriter.WriteStartDocument();
                 bsonWriter.WriteName("values");

src/MongoDB.Bson/Serialization/BsonSerializer.cs

@@ -64,11 +64,7 @@ public static bool UseZeroIdChecker
         internal static ReaderWriterLockSlim ConfigLock => _serializationDomain.ConfigLock;
 
         // public static methods
-
-        /// <summary>
-        /// //TODO
-        /// </summary>
-        /// <returns></returns>
+        //FP TODO: This is used only for testing, it can be removed later.
         internal static IBsonSerializationDomain CreateSerializationDomain() => new BsonSerializationDomain();
 
         /// <summary>

src/MongoDB.Bson/Serialization/IBsonSerializationDomain.cs

@@ -1,3 +1,18 @@
+/* Copyright 2010-present MongoDB Inc.
+*
+* Licensed under the Apache License, Version 2.0 (the "License");
+* you may not use this file except in compliance with the License.
+* You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing, software
+* distributed under the License is distributed on an "AS IS" BASIS,
+* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+* See the License for the specific language governing permissions and
+* limitations under the License.
+*/
+
 using System;
 using System.IO;
 using System.Threading;

src/MongoDB.Bson/Serialization/Serializers/TupleSerializers.cs

@@ -109,12 +109,13 @@ public sealed class TupleSerializer<T1> : SealedClassSerializerBase<Tuple<T1>>,
         // private fields
         private readonly Lazy<IBsonSerializer<T1>> _lazyItem1Serializer;
 
+        //DOMAIN-API This should be removed in the future.
         // constructors
         /// <summary>
         /// Initializes a new instance of the <see cref="TupleSerializer{T1}"/> class.
         /// </summary>
         public TupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }