RUBY-1021 Take out unnecessary self refs

Author: estolfo

lib/mongo/options/redacted.rb

@@ -25,12 +25,12 @@ class Redacted < BSON::Document
       #
       # @since 2.1.0
       SENSITIVE_OPTIONS = [ :password,
-                            :pwd ]
+                            :pwd ].freeze
 
       # The replacement string used in place of the value for sensitive keys.
       #
       # @since 2.1.0
-      STRING_REPLACEMENT = '<REDACTED>'
+      STRING_REPLACEMENT = '<REDACTED>'.freeze
 
       # Get a string representation of the options.
       #
@@ -93,12 +93,12 @@ def reject(&block)
       def reject!
         if block_given?
           n_keys = keys.size
-          self.keys.each do |key|
-            self.delete(key) if yield(key, self[key])
+          keys.each do |key|
+            delete(key) if yield(key, self[key])
           end
           n_keys == keys.size ? nil : self
         else
-          self.to_enum
+          to_enum
         end
       end
 
@@ -130,12 +130,12 @@ def select(&block)
       def select!
         if block_given?
           n_keys = keys.size
-          self.keys.each do |key|
-            self.delete(key) unless yield(key, self[key])
+          keys.each do |key|
+            delete(key) unless yield(key, self[key])
           end
           n_keys == keys.size ? nil : self
         else
-          self.to_enum
+          to_enum
         end
       end
 

lib/mongo/server_selector.rb

@@ -41,7 +41,7 @@ module ServerSelector
     # Primary read preference.
     #
     # @since 2.1.0
-    PRIMARY = Options::Redacted.new(mode: :primary)
+    PRIMARY = Options::Redacted.new(mode: :primary).freeze
 
     # Hash lookup for the selector classes based off the symbols
     #   provided in configuration.

spec/mongo/options/redacted_spec.rb

@@ -25,8 +25,12 @@
 
     context 'when the hash does not contain a sensitive key' do
 
-      it 'prints all the values' do
+      let(:original_opts) do
+        { user: 'emily' }
+      end
 
+      it 'prints all the values' do
+        expect(options.to_s).to match(original_opts[:user])
       end
     end
   end