Use errorContains: E11000 in all spec tests formerly referencing DuplicateKey (#1522)

* Use errorContains: E11000 in all spec tests formerly referencing DuplicateKey

* Guard against shards being empty

* Fix multiple mongos requirement to only apply in sharded topologies

Author: p-mongo

spec/spec_tests/data/transactions/abort.yml

@@ -305,10 +305,10 @@ tests:
           document:
             _id: 1
         result:
-          # Don't assert on errorCodeName because (after SERVER-38583) the
-          # DuplicateKey is reported in writeErrors, not as a top-level
-          # command error.
           errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
+          # DuplicateKey error code included in the bulk write error message
+          # returned by the server
+          errorContains: E11000
       # Make sure the server aborted the transaction.
       - name: insertOne
         object: collection

spec/spec_tests/data/transactions/error-labels.yml

@@ -25,10 +25,10 @@ tests:
             - _id: 1
             - _id: 1
         result:
-          # Don't assert on errorCodeName because (after SERVER-38583) the
-          # DuplicateKey is reported in writeErrors, not as a top-level
-          # command error.
           errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
+          # DuplicateKey error code included in the bulk write error message
+          # returned by the server
+          errorContains: E11000
       - name: abortTransaction
         object: session0
 

spec/spec_tests/data/transactions_api/callback-retry.yml

@@ -160,10 +160,10 @@ tests:
                 result:
                   errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
         result:
-          # Don't assert on errorCodeName because (after SERVER-38583) the
-          # DuplicateKey is reported in writeErrors, not as a top-level
-          # command error.
           errorLabelsOmit: ["TransientTransactionError", "UnknownTransactionCommitResult"]
+          # DuplicateKey error code included in the bulk write error message
+          # returned by the server
+          errorContains: E11000
     expectations:
       -
         command_started_event:

spec/support/cluster_config.rb

@@ -95,6 +95,9 @@ def storage_engine
         client = ClientRegistry.instance.global_client('root_authorized')
         if topology == :sharded
           shards = client.use(:admin).command(listShards: 1).first
+          if shards['shards'].empty?
+            raise 'Shards are empty'
+          end
           shard = shards['shards'].first
           address_str = shard['host'].sub(/^.*\//, '').sub(/,.*/, '')
           client = ClusterTools.instance.direct_client(address_str,

spec/support/transactions.rb

@@ -31,7 +31,7 @@ def define_transactions_spec_tests(test_paths)
 
           before do
             if test.multiple_mongoses?
-              unless SpecConfig.instance.addresses.length > 1
+              if ClusterConfig.instance.topology == :sharded && SpecConfig.instance.addresses.length == 1
                 skip "Test requires multiple mongoses"
               end
             else