RUBY-258 Bytebuffer#unpack takes arbitrary format string

Author: banker

lib/bson/byte_buffer.rb

@@ -236,12 +236,12 @@ def ==(other)
       other.respond_to?(:to_s) && @str == other.to_s
     end
 
-    def to_a
-      @str.unpack("C*")
+    def to_a(format="C*")
+      @str.unpack(format)
     end
 
-    def unpack(args)
-      to_a
+    def unpack(format="C*")
+      to_a(format)
     end
 
     def to_s

test/bson/byte_buffer_test.rb

@@ -21,6 +21,13 @@ def test_nil_get_returns_one_byte
     assert_equal 1, @buf.get
   end
 
+  def test_unpack
+    @buf.put_array([17, 2, 3, 4])
+    assert_equal [17, 2, 3, 4], @buf.to_a
+    assert_equal ["11020304"], @buf.unpack("H*")
+    assert_equal ["11020304"], @buf.to_a("H*")
+  end
+
   def test_one_get_returns_array_length_one
     @buf.put_array([1, 2, 3, 4])
     @buf.rewind