Merge pull request #810 from estolfo/RUBY-1122-handle-auth-failure

RUBY-1122 Mark a server as unknown when auth fails

Author: estolfo

lib/mongo/server.rb

@@ -63,7 +63,8 @@ class Server
                    :replica_set_name,
                    :secondary?,
                    :standalone?,
-                   :unknown?
+                   :unknown?,
+                   :unknown!
 
     # Is this server equal to another?
     #
@@ -229,5 +230,24 @@ def reconnect!
     def with_connection(&block)
       pool.with_connection(&block)
     end
+
+    # Handle authentication failure.
+    #
+    # @example Handle possible authentication failure.
+    #   server.handle_auth_failure! do
+    #     Auth.get(user).login(self)
+    #   end
+    #
+    # @raise [ Auth::Unauthorized ] If the authentication failed.
+    #
+    # @return [ Object ] The result of the block execution.
+    #
+    # @since 2.3.0
+    def handle_auth_failure!
+      yield
+    rescue Auth::Unauthorized
+      unknown!
+      raise
+    end
   end
 end

lib/mongo/server/connection.rb

@@ -162,7 +162,9 @@ def deliver(messages)
       def authenticate!
         if options[:user]
           user = Auth::User.new(Options::Redacted.new(:auth_mech => default_mechanism).merge(options))
-          Auth.get(user).login(self)
+          @server.handle_auth_failure! do
+            Auth.get(user).login(self)
+          end
         end
       end
 

spec/mongo/server/connection_spec.rb

@@ -113,7 +113,8 @@
             TEST_OPTIONS.merge(
               :user => 'notauser',
               :password => 'password',
-              :database => TEST_DB )
+              :database => TEST_DB,
+              :heartbeat_frequency => 30)
           )
         end
 
@@ -130,7 +131,6 @@
         end
 
         it 'marks the server as unknown' do
-          pending 'Server must be set as unknown'
           expect(server).to be_unknown
         end
       end