RUBY-2328: backport zlib compression integration test (#2025)

Author: Emily Giurleo

.evergreen/config.yml

@@ -88,6 +88,7 @@ functions:
               export WITH_ACTIVE_SUPPORT="${WITH_ACTIVE_SUPPORT}"
               export SINGLE_MONGOS="${SINGLE_MONGOS}"
               export MMAPV1="${MMAPV1}"
+              export COMPRESSOR="${COMPRESSOR}"
 
               export STRESS_SPEC=true
            EOT
@@ -574,7 +575,7 @@ axes:
         display_name: "2.6"
         variables:
            VERSION: "2.6"
-  
+
   - id: fcv
     display_name: FCV
     values:
@@ -598,7 +599,7 @@ axes:
         display_name: Sharded
         variables:
            TOPOLOGY: "sharded_cluster"
-  
+
   - id: "auth-and-ssl"
     display_name: Authentication and SSL
     values:
@@ -622,7 +623,7 @@ axes:
         variables:
            AUTH: "noauth"
            SSL: "nossl"
-  
+
   - id: "ruby"
     display_name: Ruby Version
     # Local TLS tests run on all Ruby versions, thus no versions should be
@@ -656,7 +657,7 @@ axes:
         display_name: jruby-9.2
         variables:
            RVM_RUBY: "jruby-9.2"
-  
+
   - id: "os"
     display_name: OS
     values:
@@ -669,47 +670,47 @@ axes:
       - id: rhel70
         display_name: "RHEL 7.0"
         run_on: rhel70-small
-  
+
   - id: "compressor"
     display_name: Compressor
     values:
       - id: "zlib"
         display_name: Zlib
         variables:
            COMPRESSOR: "zlib"
-  
+
   - id: retry-reads
     display_name: Retry Reads
     values:
       - id: no-retry-reads
         display_name: No Retry Reads
         variables:
           RETRY_READS: 'false'
-  
+
   - id: retry-writes
     display_name: Retry Writes
     values:
       - id: no-retry-writes
         display_name: No Retry Writes
         variables:
           RETRY_WRITES: 'false'
-  
+
   - id: lint
     display_name: Lint
     values:
       - id: on
         display_name: On
         variables:
           LINT: '1'
-  
+
   - id: "as"
     display_name: ActiveSupport
     values:
       - id: "as"
         display_name: AS
         variables:
           WITH_ACTIVE_SUPPORT: true
-  
+
   - id: bson
     display_name: BSON
     values:
@@ -721,15 +722,15 @@ axes:
         display_name: master
         variables:
           BSON: master
-  
+
   - id: "single-mongos"
     display_name: Single Mongos
     values:
       - id: "single-mongos"
         display_name: Single Mongos
         variables:
           SINGLE_MONGOS: 'true'
-  
+
   - id: storage-engine
     display_name: Storage Engine
     values:

.evergreen/functions.sh

@@ -74,7 +74,6 @@ set_env_vars() {
   fi
 
   export MONGODB_URI
-  export COMPRESSOR
 
   export CI=evergreen
 

spec/integration/zlib_compression_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe 'Zlib compression' do
+  require_compression
+
+  before do
+    authorized_client['test'].drop
+  end
+
+  context 'when client has zlib compressor option enabled' do
+    it 'compresses the message to the server' do
+      # Double check that the client has zlib compression enabled
+      expect(authorized_client.options[:compressors]).to include('zlib')
+
+      expect(Mongo::Protocol::Compressed).to receive(:new).twice.and_call_original
+      expect(Zlib::Deflate).to receive(:deflate).twice.and_call_original
+      expect(Zlib::Inflate).to receive(:inflate).twice.and_call_original
+
+      authorized_client['test'].insert_one(_id: 1, text: 'hello world')
+      document = authorized_client['test'].find(_id: 1).first
+
+      expect(document['text']).to eq('hello world')
+    end
+  end
+end

spec/mongo/auth/user/view_spec.rb

@@ -109,8 +109,7 @@
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end
@@ -197,8 +196,7 @@
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end
@@ -247,8 +245,7 @@
           min_server_fcv '3.6'
 
           it 'does not compress the message' do
-            # The dropUser command message will be compressed, so expect instantiation once.
-            expect(Mongo::Protocol::Compressed).to receive(:new).once.and_call_original
+            expect(Mongo::Protocol::Compressed).not_to receive(:new)
             expect(response).to be_successful
           end
         end

spec/mongo/client_construction_spec.rb

@@ -235,7 +235,8 @@
             min_server_fcv '3.6'
 
             it 'uses compression for messages' do
-              expect(Mongo::Protocol::Compressed).to receive(:new).and_call_original
+              # A Compressed object will be created for both the request and the response
+              expect(Mongo::Protocol::Compressed).to receive(:new).twice.and_call_original
               client[TEST_COLL].find({}, limit: 1).first
             end
           end

spec/support/spec_config.rb

@@ -133,10 +133,10 @@ def active_support?
 
   # What compressor to use, if any.
   def compressors
-    if ENV['COMPRESSORS']
-      ENV['COMPRESSORS'].split(',')
-    else
+    if ENV['COMPRESSOR'].nil? || ENV['COMPRESSOR'].empty?
       nil
+    else
+      [ENV['COMPRESSOR']]
     end
   end