Fixed unit tests

Author: igor-karpukhin

internal/controller/atlasorgsettings/atlasorgsettings_controller.go

@@ -18,6 +18,7 @@ import (
 	"github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/atlas"
 	"github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/controller/reconciler"
 	"github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/indexer"
+	"github.com/mongodb/mongodb-atlas-kubernetes/v2/internal/translation/atlasorgsettings"
 	ctrlstate "github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/controller/state"
 	mckpredicate "github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/predicate"
 )
@@ -28,10 +29,14 @@ import (
 // +kubebuilder:rbac:groups=atlas.mongodb.com,namespace=default,resources=atlasorgsettings,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=atlas.mongodb.com,namespace=default,resources=atlasorgsettings/status,verbs=get;update;patch
 // +kubebuilder:rbac:groups=atlas.mongodb.com,namespace=default,resources=atlasorgsettings/finalizers,verbs=update
+
+type serviceBuilderFunc func(*atlas.ClientSet) atlasorgsettings.AtlasOrgSettingsService
+
 type AtlasOrgSettingsHandler struct {
 	ctrlstate.StateHandler[akov2.AtlasOrgSettings]
 	reconciler.AtlasReconciler
 	deletionProtection bool
+	serviceBuilder     serviceBuilderFunc
 }
 
 func NewAtlasOrgSettingsReconciler(
@@ -49,6 +54,10 @@ func NewAtlasOrgSettingsReconciler(
 			Log:             logger.Named("controllers").Named("AtlasOrgSettings").Sugar(),
 			GlobalSecretRef: globalSecretRef,
 		},
+		deletionProtection: deletionProtection,
+		serviceBuilder: func(clientSet *atlas.ClientSet) atlasorgsettings.AtlasOrgSettingsService {
+			return atlasorgsettings.NewAtlasOrgSettingsService(clientSet.SdkClient20250312006.OrganizationsApi)
+		},
 	}
 	return ctrlstate.NewStateReconciler(
 		orgSettingsHandler,

internal/controller/atlasorgsettings/handler.go

@@ -38,7 +38,7 @@ func (h *AtlasOrgSettingsHandler) newReconcileContext(ctx context.Context, aos *
 		return nil, err
 	}
 	return &reconcileContext{
-		svc: atlasorgsettings.NewAtlasOrgSettingsService(atlasSdk.SdkClient20250312006.OrganizationsApi),
+		svc: h.serviceBuilder(atlasSdk),
 		aos: aos,
 	}, nil
 }
@@ -59,11 +59,11 @@ func (h *AtlasOrgSettingsHandler) upsert(ctx context.Context, currentState, next
 		return result.Error(currentState, fmt.Errorf("atlas returned OrgSettings which is nil after update"))
 	}
 
-	return result.NextState(state.StateCreated, "Initialized")
+	return result.NextState(nextState, "Initialized")
 }
 
 func (h *AtlasOrgSettingsHandler) unmanage(orgID string) (ctrlstate.Result, error) {
-	return result.NextState(state.StateDeleted, fmt.Sprintf("unmanaged is AtlasOrgSettings for orgID %s", orgID))
+	return result.NextState(state.StateDeleted, fmt.Sprintf("unmanaged is AtlasOrgSettings for orgID %s.", orgID))
 }
 
 func (h *AtlasOrgSettingsHandler) HandleInitial(ctx context.Context, aos *akov2.AtlasOrgSettings) (ctrlstate.Result, error) {