Run pre-commit generation jobs in parallel

Update generate_files.sh to run all generation/validation jobs
concurrently for faster execution. The script:
- Runs all independent jobs in background
- Properly handles dependency: generate_standalone_yaml waits for
  update_release_json and update_values_yaml_files to complete first
- Prefixes job output for easy debugging
- Reports failures with job names and PIDs

Author: nammn

.pre-commit-config.yaml

@@ -102,74 +102,12 @@ repos:
         args: [--timeout=10m]
 
   # Local hooks for project-specific tasks
+  # Runs all generation/validation jobs in parallel internally
   - repo: local
     hooks:
-      - id: update-release-json
-        name: update-release-json
-        entry: scripts/dev/generate_files.sh update_release
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: update-values-yaml
-        name: update-values-yaml
-        entry: scripts/dev/generate_files.sh update_values
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: generate-standalone-yaml
-        name: generate-standalone-yaml
-        entry: scripts/dev/generate_files.sh generate_standalone_yaml
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: generate-manifests
-        name: generate-manifests
-        entry: scripts/dev/generate_files.sh generate_manifests
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: regenerate-mco-tests
-        name: regenerate-mco-tests
-        entry: scripts/dev/generate_files.sh update_mco_tests
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: regenerate-multicluster-rbac
-        name: regenerate-multicluster-rbac
-        entry: scripts/dev/regenerate_multicluster_rbac.sh
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: update-licenses
-        name: update-licenses
-        entry: scripts/dev/generate_files.sh update_licenses
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: validate-snippets
-        name: validate-snippets
-        entry: scripts/code_snippets/validate_snippets.py
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: check-kubebuilder-annotations
-        name: check-kubebuilder-annotations
-        entry: bash -c 'if grep -r "// kubebuilder" --include="*.go" --exclude-dir=vendor .; then echo "Found erroneous kubebuilder annotation"; exit 1; fi'
-        language: system
-        pass_filenames: false
-        stages: [pre-commit]
-
-      - id: helm-lint
-        name: helm-lint
-        entry: scripts/dev/lint_helm_chart.sh
+      - id: generate-and-validate
+        name: generate-and-validate (parallel)
+        entry: scripts/dev/generate_files.sh generate_all
         language: system
         pass_filenames: false
         stages: [pre-commit]

scripts/dev/generate_files.sh

@@ -123,16 +123,6 @@ update_licenses() {
   fi
 }
 
-# Main update jobs - runs the generation tasks
-update_jobs() {
-  # Update release.json first in case there is a newer version
-  time update_release_json
-  # We need to generate the values files first
-  time update_values_yaml_files
-  # The values files are used for generating the standalone yaml
-  time generate_standalone_yaml
-}
-
 # bg_job_ vars are global; run_job_in_background function is appending to them on each call
 bg_job_pids=()
 bg_job_pids_with_names=()
@@ -178,13 +168,51 @@ wait_for_all_background_jobs() {
   return 0
 }
 
+validate_snippets() {
+  scripts/code_snippets/validate_snippets.py
+}
+
+check_kubebuilder_annotations() {
+  if grep -r "// kubebuilder" --include="*.go" --exclude-dir=vendor .; then
+    echo "Found erroneous kubebuilder annotation"
+    return 1
+  fi
+}
+
+helm_lint() {
+  scripts/dev/lint_helm_chart.sh
+}
+
 generate_all() {
-  run_job_in_background "update_jobs"
-  run_job_in_background "update_licenses"
+  title "Running pre-commit jobs in parallel"
+
+  # Phase 1: Run generation jobs - some have dependencies
+  # update_release and update_values must run before generate_standalone_yaml
+  run_job_in_background "update_release_json"
+  run_job_in_background "update_values_yaml_files"
+
+  # These can run in parallel with the above
+  run_job_in_background "generate_manifests"
+  run_job_in_background "update_mco_tests"
   run_job_in_background "regenerate_public_rbac_multi_cluster"
+  run_job_in_background "update_licenses"
+  run_job_in_background "validate_snippets"
+  run_job_in_background "check_kubebuilder_annotations"
+  run_job_in_background "helm_lint"
+
+  # Wait for update_release and update_values to complete before generate_standalone_yaml
+  local release_pid="${bg_job_pids[0]}"
+  local values_pid="${bg_job_pids[1]}"
+
+  wait "${release_pid}" || true
+  wait "${values_pid}" || true
+
+  # Now run generate_standalone_yaml (depends on values files)
+  run_job_in_background "generate_standalone_yaml"
 
+  # Wait for all remaining jobs
   if wait_for_all_background_jobs; then
-    echo -e "${GREEN}generate_files: All generation jobs completed!${NO_COLOR}"
+    echo -e "${GREEN}All pre-commit jobs completed successfully!${NO_COLOR}"
     return 0
   else
     return 1