Add tests for retry loop and backoff.

Author: baileympearson

src/operations/execute_operation.ts

@@ -38,6 +38,7 @@ import {
 } from '../utils';
 import { AggregateOperation } from './aggregate';
 import { AbstractOperation, Aspect } from './operation';
+import { RunCommandOperation } from './run_command';
 
 const MMAPv1_RETRY_WRITES_ERROR_CODE = MONGODB_ERROR_CODES.IllegalOperation;
 const MMAPv1_RETRY_WRITES_ERROR_MESSAGE =
@@ -264,16 +265,16 @@ async function executeOperationWithRetries<
       if (previousOperationError.hasErrorLabel(MongoErrorLabel.SystemOverloadedError)) {
         systemOverloadRetryAttempt += 1;
 
+        // if retryable writes or reads are not configured, throw.
+        const isOperationConfiguredForRetry =
+          (hasReadAspect && topology.s.options.retryReads) ||
+          (hasWriteAspect && topology.s.options.retryWrites);
+        const isRunCommand = operation instanceof RunCommandOperation;
+
         if (
           // if the SystemOverloadError is not retryable, throw.
           !previousOperationError.hasErrorLabel(MongoErrorLabel.RetryableError) ||
-          !(
-            // if retryable writes or reads are not configured, throw.
-            (
-              (hasReadAspect && topology.s.options.retryReads) ||
-              (hasWriteAspect && topology.s.options.retryWrites)
-            )
-          )
+          !(isOperationConfiguredForRetry || isRunCommand)
         ) {
           throw previousOperationError;
         }
@@ -360,7 +361,10 @@ async function executeOperationWithRetries<
 
     try {
       // If attempt > 0 and we are command batching we need to reset the batch.
-      if (nonOverloadRetryAttempt > 0 && operation.hasAspect(Aspect.COMMAND_BATCHING)) {
+      if (
+        (nonOverloadRetryAttempt > 0 || systemOverloadRetryAttempt > 0) &&
+        operation.hasAspect(Aspect.COMMAND_BATCHING)
+      ) {
         operation.resetBatch();
       }
 

sync.sh

@@ -0,0 +1,3 @@
+
+
+cp ~/dev/specifications/source/client-backpressure/tests/* ~/dev/node-mongodb-native/test/spec/client-backpressure

test/integration/client-backpressure/client-backpressure.spec.test.ts

@@ -0,0 +1,16 @@
+import { loadSpecTests } from '../../spec';
+import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';
+import { type Test } from '../../tools/unified-spec-runner/schema';
+
+const skippedTests = {
+  'collection.dropIndexes retries at most maxAttempts times (maxAttempts=5)':
+    'TODO(NODE-6517): dropIndexes squashes all errors other than ns not found'
+};
+
+function shouldSkip({ description }: Test) {
+  return skippedTests[description] ?? false;
+}
+
+describe('Client Backpressure (spec)', function () {
+  runUnifiedSuite(loadSpecTests('client-backpressure'), shouldSkip);
+});

test/spec/client-backpressure/README.md

@@ -0,0 +1,15 @@
+# Client Backpressure Tests
+
+______________________________________________________________________
+
+## Introduction
+
+The YAML and JSON files in this directory are platform-independent tests meant to exercise a driver's implementation of
+retryable reads. These tests utilize the [Unified Test Format](../../unified-test-format/unified-test-format.md).
+
+Several prose tests, which are not easily expressed in YAML, are also presented in this file. Those tests will need to
+be manually implemented by each driver.
+
+## Changelog
+
+- 2025-XX-XX: Initial version.