From a0d0f9144b456eef3ef8adcff798785133bee1a3 Mon Sep 17 00:00:00 2001 From: ackerapple Date: Mon, 3 Oct 2016 14:23:32 -0400 Subject: [PATCH 1/2] added omitPageNumOnFileName option to convertPage function --- .DS_Store | Bin 0 -> 6148 bytes README.md | 4 ++++ index.js | 15 ++++++++------- package.json | 2 +- tests/test-main.js | 2 ++ 5 files changed, 15 insertions(+), 8 deletions(-) create mode 100644 .DS_Store diff --git a/.DS_Store b/.DS_Store new file mode 100644 index 0000000000000000000000000000000000000000..51227d71a94e52683c4d00d01ac912a7dfa75f3b GIT binary patch literal 6148 zcmeHKI|>3p3{CuiU}I@HSMUad=n3`$7K)81_^Y?_TprDrPoXS!S|~4&yqQeiEc=Sh zMnrUeSOjyq1*=D6P-_S;VFyM%Fva+Zyp5TE&WLZbpy zfC^9nDnJE3tw46z(fHFB^FAs-1%6%u`#u!7VNGlU{nLTqBLHxKv>VnwO8|={fHkoV zL$0gG>bW2DSK<@<*e5h_zG?{ceokWPC@W?4D@!4jkV*c7e!sMHO^~d U8|ZZ8oet#BfayY`0^e5P0W;M1& literal 0 HcmV?d00001 diff --git a/README.md b/README.md index 2ac37b4..9798e36 100644 --- a/README.md +++ b/README.md @@ -28,6 +28,10 @@ pdfImage.convertPage(0).then(function (imagePath) { fs.existsSync("/tmp/slide-0.png") // => true }); ``` +> Note: If you do NOT want page numbers in your image file names, use option "omitPageNumOnFileName" +``` +pdfImage.convertPage(0, {omitPageNumOnFileName:true}).then() +``` ## Express diff --git a/index.js b/index.js index ee5dd64..b7fe46d 100644 --- a/index.js +++ b/index.js @@ -59,10 +59,11 @@ PDFImage.prototype = { return info["Pages"]; }); }, - getOutputImagePathForPage: function (pageNumber) { + /** @options{omitPageNumOnFileName:Boolean} */ + getOutputImagePathForPage: function (pageNumber, options) { return path.join( this.outputDirectory, - this.pdfFileBaseName + "-" + pageNumber + "." + this.convertExtension + this.pdfFileBaseName + (!options||!options.omitPageNumOnFileName?"-"+pageNumber:"") + "." + this.convertExtension ); }, setConvertOptions: function (convertOptions) { @@ -71,9 +72,9 @@ PDFImage.prototype = { setConvertExtension: function (convertExtension) { this.convertExtension = convertExtension || "png"; }, - constructConvertCommandForPage: function (pageNumber) { + constructConvertCommandForPage: function (pageNumber, options) { var pdfFilePath = this.pdfFilePath; - var outputImagePath = this.getOutputImagePathForPage(pageNumber); + var outputImagePath = this.getOutputImagePathForPage(pageNumber, options); var convertOptionsString = this.constructConvertOptions(); return util.format( "%s %s'%s[%d]' '%s'", @@ -91,10 +92,10 @@ PDFImage.prototype = { } }, this).join(" "); }, - convertPage: function (pageNumber) { + convertPage: function (pageNumber, options) { var pdfFilePath = this.pdfFilePath; - var outputImagePath = this.getOutputImagePathForPage(pageNumber); - var convertCommand = this.constructConvertCommandForPage(pageNumber); + var outputImagePath = this.getOutputImagePathForPage(pageNumber, options); + var convertCommand = this.constructConvertCommandForPage(pageNumber, options); var promise = new Promise(function (resolve, reject) { function convertPageToImage() { diff --git a/package.json b/package.json index c090775..84e4de4 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "pdf-image", - "version": "1.0.2", + "version": "1.0.3", "main": "index.js", "repository": { "type": "git", diff --git a/tests/test-main.js b/tests/test-main.js index b5af150..0a7684e 100644 --- a/tests/test-main.js +++ b/tests/test-main.js @@ -24,6 +24,8 @@ describe("PDFImage", function () { .equal("/tmp/test-2.png"); expect(pdfImage.getOutputImagePathForPage(1000)) .equal("/tmp/test-1000.png"); + expect(pdfImage.getOutputImagePathForPage(1000,{omitPageNumOnFileName:true})) + .equal("/tmp/test.png"); }); it("should return correct convert command", function () { From 47c1c1c06d9174e89fe29c9799bb8df4aea7ec8c Mon Sep 17 00:00:00 2001 From: Acker Dawn Apple Date: Mon, 3 Oct 2016 14:27:42 -0400 Subject: [PATCH 2/2] Delete .DS_Store --- .DS_Store | Bin 6148 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .DS_Store diff --git a/.DS_Store b/.DS_Store deleted file mode 100644 index 51227d71a94e52683c4d00d01ac912a7dfa75f3b..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6148 zcmeHKI|>3p3{CuiU}I@HSMUad=n3`$7K)81_^Y?_TprDrPoXS!S|~4&yqQeiEc=Sh zMnrUeSOjyq1*=D6P-_S;VFyM%Fva+Zyp5TE&WLZbpy zfC^9nDnJE3tw46z(fHFB^FAs-1%6%u`#u!7VNGlU{nLTqBLHxKv>VnwO8|={fHkoV zL$0gG>bW2DSK<@<*e5h_zG?{ceokWPC@W?4D@!4jkV*c7e!sMHO^~d U8|ZZ8oet#BfayY`0^e5P0W;M1&