Can't rename browser

[vdb86]

Hi!
I'm running BP 2.2.4 on windows 10 pro.
I've renamed Mozilla Firefox to Firefox but when I start BP again, it goes back to Mozilla Firefox.

Please let me know if you need any more info from my end.

[mortenn]

Hi, are you enabling the option "Disable automatic updates"?
If not, the name resetting is expected.
If you are, there may still be some cases where it resets according to reports, I suspect a race issue is to blame for that, but I have not yet had the time to investigate.

[vdb86]

Hi!
I've selected Disable automatic updates, but that setting doesn't get saved.
If I Edit the browser without exiting Browser Picker I see that the checkbox is unchecked, even though it was checked.

[IAmWhitBran]

I am also having this issue.
Not much more to add to the topic, other than for me this is a problem with Edge, I want to include each of my profiles on the list and give them separate names.
The settings to not seem to get saved for anything when I press done.

---

Update; I assume this relates to #157

[mortenn]

pretty sure this is the same race condition that has been reported elsewhere, the issue is that settings get overwritten by the scanner before the old settings have loaded, thus making it ignore the option to disable updates.

I don't have a quick fix for this, it will likely mean refactoring the settings system entirely, which currently very heavily relies on property change notifications.

[Countryen]

Hey there, today I tried this app out and noticed the same but got it working by just changing the reg-keys myself. Here I will include all details to hopefully get this fixed sooner than later as I really love the concept of the app.

Browser Picker seems to use the following key to store settings: HKCU\Software\BrowserPicker\

I've noticed after multiple attempts of renaming my 3 firefoxes that each time I rename them a new key under BrowserLists is created, but without much of the values. So I assume the following happens:

• When the app saves the profiles (when you click "Done" or exit the app)
• it saves each profile to an individual key under "BrowserLists" matching the name of the browser
• since you changed that name it messes up and creates a new key instead of renaming the existing key
• then it saves only the actual changed properties (maybe there is a diff in play?)
• since you only changed the name, there is not much to save
• when the app loads again, the "invalid profile" is not shown, although it is there in the reg

How to fix:
(This is intended for bug fixing only, please do only do this if you absolutely know what you are doing. Never try to change things yourself in the registry without a backup as this might cause real damage)

• Open registry editor
• Go to HKCU\Software\BrowserPicker\BrowserList
• Rename one of the keys
  • Example: Change "Mozilla Firefox" to "Firefox"
• Start the browser picker
• Observe the changed name

Note it works but is quirky. Browser Picker automatically added in the "normal" firefoxes but I just disabled them afterwards, the "renamed ones" stay the way I like them. Not sure though how the value Name is used, I did not change it, the app seems to just display the name of the key instead anyways.

[Countryen]

To make it a bit easier, here are some images for above

my registry

results