Skip to content
This repository was archived by the owner on Sep 2, 2020. It is now read-only.

Conversation

@andrewhayward
Copy link
Contributor

Not sure where's best to include tests for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line might be a little too clever, it's hard to tell at a glance what's going on. Should probably break it into steps.

Alternatively, you can probably use url.parse:

const scheme = urlUtil.parse('' + url).scheme
if (scheme === 'data:')
  return createFromData(url, callback);

@brianloveswords
Copy link
Contributor

As for tests, I'd create a new test file for image-helper stuff.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants