From b50b8af303c2b6713887e5e13bb4ec5dcff9ac85 Mon Sep 17 00:00:00 2001 From: Mark Reid Date: Tue, 6 May 2025 20:50:24 -0300 Subject: [PATCH] Update sql_style.md Add guidance around placement of commas --- src/concepts/sql_style.md | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/src/concepts/sql_style.md b/src/concepts/sql_style.md index d36e86892..6281cb1c9 100644 --- a/src/concepts/sql_style.md +++ b/src/concepts/sql_style.md @@ -368,6 +368,41 @@ WHERE sample_id = '42' ``` +## Comma at the End of the Line + +Commas between `SELECT` elements should always be at the end of the line. +For example: + +**Good** + +```sql +SELECT + client_id, + os_name, + submission_date +FROM + main_summary +WHERE + submission_date > '20180101' +LIMIT + 10 +``` + +**Bad** + +```sql +SELECT + client_id + , os_name + , submission_date +FROM + main_summary +WHERE + submission_date > '20180101' +LIMIT + 10 +``` + ## Nested Queries Do not use nested queries.