Fix #20420: Prevent double decoding of file URL parameter

Uzair-Ahmed-Shah · Uzair-Ahmed-Shah · commit d1d7d91e5d7e · 2025-12-04T22:35:46.000+05:30
diff --git a/web/app.js b/web/app.js
@@ -789,7 +789,7 @@ const PDFViewerApplication = {
       const params = parseQueryString(queryString);
       file = params.get("file") ?? AppOptions.get("defaultUrl");
       try {
-        file = new URL(decodeURIComponent(file)).href;
+        file = new URL(file).href;
       } catch {
         file = encodeURIComponent(file).replaceAll("%2F", "/");
       }

Original file line number	Diff line number	Diff line change
`@@ -789,7 +789,7 @@ const PDFViewerApplication = {`
`789`	`789`	`const params = parseQueryString(queryString);`
`790`	`790`	`file = params.get("file") ?? AppOptions.get("defaultUrl");`
`791`	`791`	`try {`
`792`		`- file = new URL(decodeURIComponent(file)).href;`
	`792`	`+ file = new URL(file).href;`
`793`	`793`	`} catch {`
`794`	`794`	`file = encodeURIComponent(file).replaceAll("%2F", "/");`
`795`	`795`	`}`