fix!(frecency): Use byte strings for DB IDs

Author: mrjones2014

lua/legendary/api/db/client.lua

@@ -81,8 +81,8 @@ function M.update_item_score(item)
   M.db_wrapper:update(item)
 end
 
-function M.sql_escape(str)
-  return M.db_wrapper.sql_escape(str)
+function M.to_bytes(str)
+  return M.db_wrapper.to_bytes(str)
 end
 
 function M.get_client()

lua/legendary/api/db/wrapper.lua

@@ -155,14 +155,18 @@ local function row_id(row)
   return (not vim.tbl_isempty(row)) and row[1].id or nil
 end
 
-function M.sql_escape(str)
-  return string.format("'%s'", string.gsub(str, "'", "\\'"))
+function M.to_bytes(str)
+  local result = ''
+  for c in str:gmatch('.') do
+    result = result .. string.byte(c)
+  end
+  return result
 end
 
 ---Update the stored data for an item
 ---@param item LegendaryItem
 function M:update(item)
-  local item_id = M.sql_escape(item:frecency_id())
+  local item_id = M.to_bytes(item:frecency_id())
   Log.trace('Updating item with ID "%s"', item_id)
   local entry_id = row_id(self:transaction(self.queries.item_get_entries, { where = { item_id = item_id } }))
   if not entry_id then

lua/legendary/data/itemlist.lua

@@ -164,8 +164,8 @@ function ItemList:sort_inplace(opts)
         ---@param item1 LegendaryItem
         ---@param item2 LegendaryItem
         function(item1, item2)
-          local item1_id = DbClient.sql_escape(item1:frecency_id())
-          local item2_id = DbClient.sql_escape(item2:frecency_id())
+          local item1_id = DbClient.to_bytes(item1:frecency_id())
+          local item2_id = DbClient.to_bytes(item2:frecency_id())
           local item1_score = frecency_scores[item1_id] or 0
           local item2_score = frecency_scores[item2_id] or 0
           return item1_score > item2_score