Ensure we click <input type="submit"> elements

mrmr1993 · mrmr1993 · commit 09f8527915ea · 2014-12-16T22:04:28.000Z
diff --git a/lib/dom_utils.coffee b/lib/dom_utils.coffee
@@ -95,11 +95,11 @@ DomUtils =
   #
   # The html5 input types that should use simulateSelect are:
   #   ["date", "datetime", "datetime-local", "email", "month", "number", "password", "range", "search",
-  #    "submit", "tel", "text", "time", "url", "week"]
+  #    "tel", "text", "time", "url", "week"]
   # An unknown type will be treated the same as "text", in the same way that the browser does.
   #
   isSelectable: (element) ->
-    unselectableTypes = ["button", "checkbox", "color", "file", "hidden", "image", "radio", "reset"]
+    unselectableTypes = ["button", "checkbox", "color", "file", "hidden", "image", "radio", "reset", "submit"]
     (element.nodeName.toLowerCase() == "input" && unselectableTypes.indexOf(element.type) == -1) ||
         element.nodeName.toLowerCase() == "textarea"
 

Original file line number	Diff line number	Diff line change
`@@ -95,11 +95,11 @@ DomUtils =`
`95`	`95`	`#`
`96`	`96`	`# The html5 input types that should use simulateSelect are:`
`97`	`97`	`# ["date", "datetime", "datetime-local", "email", "month", "number", "password", "range", "search",`
`98`		`- # "submit", "tel", "text", "time", "url", "week"]`
	`98`	`+ # "tel", "text", "time", "url", "week"]`
`99`	`99`	`# An unknown type will be treated the same as "text", in the same way that the browser does.`
`100`	`100`	`#`
`101`	`101`	`isSelectable: (element) ->`
`102`		`- unselectableTypes = ["button", "checkbox", "color", "file", "hidden", "image", "radio", "reset"]`
	`102`	`+ unselectableTypes = ["button", "checkbox", "color", "file", "hidden", "image", "radio", "reset", "submit"]`
`103`	`103`	`(element.nodeName.toLowerCase() == "input" && unselectableTypes.indexOf(element.type) == -1) \|\|`
`104`	`104`	`element.nodeName.toLowerCase() == "textarea"`
`105`	`105`