-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Open
Description
What's wrong
When new agent directories are added, all four places that enumerate directories need to stay in sync:
| File | Purpose |
|---|---|
scripts/lint-agents.sh AGENT_DIRS |
local full-scan linting |
.github/workflows/lint-agents.yml paths |
CI trigger |
.github/workflows/lint-agents.yml git diff |
CI changed-file detection |
scripts/convert.sh AGENT_DIRS |
format conversion |
scripts/install.sh install loops |
local installation |
Currently two directories are out of sync:
| Directory | lint-agents.sh | lint-agents.yml | convert.sh | install.sh |
|---|---|---|---|---|
academic/ (5 agents) |
✗ | ✗ | ✓ | ✓ |
sales/ (8 agents) |
✗ | ✓ | ✓ | ✓ |
academic/was added in feat: add Academic Division with 5 storytelling agents #219 withconvert.shandinstall.shupdates, butlint-agents.shandlint-agents.ymlwere not updated. PRs touchingacademic/agents will never trigger CI lint.sales/is covered by CI (so PRs do trigger lint), butlint-agents.shAGENT_DIRSis missing it, so a local./scripts/lint-agents.shwith no arguments silently skipssales/.
Reproduction
# academic/ agents are invisible to local lint:
./scripts/lint-agents.sh | head -1
# → "Linting NN agent files..." — count does not include academic/ or sales/
# Verify by linting explicitly — works fine:
./scripts/lint-agents.sh academic/*.mdSuggested fix
- Add
academicandsalestoAGENT_DIRSinscripts/lint-agents.sh - Add
'academic/**'topathsand thegit diffglob list in.github/workflows/lint-agents.yml
Happy to open a PR for this.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels