Skip to content

[Bug] lint-agents.sh and CI workflow missing academic/ and sales/ directories #242

@Astro-Han

Description

@Astro-Han

What's wrong

When new agent directories are added, all four places that enumerate directories need to stay in sync:

File Purpose
scripts/lint-agents.sh AGENT_DIRS local full-scan linting
.github/workflows/lint-agents.yml paths CI trigger
.github/workflows/lint-agents.yml git diff CI changed-file detection
scripts/convert.sh AGENT_DIRS format conversion
scripts/install.sh install loops local installation

Currently two directories are out of sync:

Directory lint-agents.sh lint-agents.yml convert.sh install.sh
academic/ (5 agents)
sales/ (8 agents)
  • academic/ was added in feat: add Academic Division with 5 storytelling agents #219 with convert.sh and install.sh updates, but lint-agents.sh and lint-agents.yml were not updated. PRs touching academic/ agents will never trigger CI lint.
  • sales/ is covered by CI (so PRs do trigger lint), but lint-agents.sh AGENT_DIRS is missing it, so a local ./scripts/lint-agents.sh with no arguments silently skips sales/.

Reproduction

# academic/ agents are invisible to local lint:
./scripts/lint-agents.sh | head -1
# → "Linting NN agent files..." — count does not include academic/ or sales/

# Verify by linting explicitly — works fine:
./scripts/lint-agents.sh academic/*.md

Suggested fix

  1. Add academic and sales to AGENT_DIRS in scripts/lint-agents.sh
  2. Add 'academic/**' to paths and the git diff glob list in .github/workflows/lint-agents.yml

Happy to open a PR for this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions