Skip to content

The arguments of self.start_helper_thread() should be more flexible instead of fixed as int64. #69

@gouchangjiang

Description

@gouchangjiang

Hi, Line 320 of /runtime/communication.py should be set as [target_tensor_name, i, self.training_tensor_dtypes[target_tensor_name], , otherwise if one of the target to calculate the loss is not type int64, there will be an error.

The original code snippet:
self.start_helper_thread( self.recv_helper_thread_args, recv_helper_thread, [target_tensor_name, i, torch.int64, False], num_iterations_for_backward_threads)
, my suggestion is:
self.start_helper_thread( self.recv_helper_thread_args, recv_helper_thread, [target_tensor_name, i, self.training_tensor_dtypes[target_tensor_name], False], num_iterations_for_backward_threads).
In this case, the code is consistent with the data type specified in the main.py file.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions