Skip to content
This repository was archived by the owner on Feb 17, 2023. It is now read-only.
This repository was archived by the owner on Feb 17, 2023. It is now read-only.

Browser type exported (public), does it need to be? #76

@aren55555

Description

@aren55555

Description

I found this library (appreciate your OSS contribution) and was looking thru the GoDoc to gain an understanding of the package's API structure.

I was wondering about the Browser type. It's part of the public API, it doesn't seem to be exposed by any of the public functions or as a public field of the other exported types. To me, it appears that this type should not be exported, and should be renamed from Browser to browser.

It's also possible that perhaps that the receiver method:

func (p *UserAgent) Browser() (string, string)

Should instead be exposed as:

func (p *UserAgent) Browser() Browser

What do you think?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions