PHP 8.4 Compatibility: Deprecated Warnings in Model Constructors (Nullable Parameters)

[tim-hanssen]

When using the SDK with PHP 8.4 (and 8.3), several deprecation warnings are thrown due to implicitly nullable parameters in model constructors.

Example:

MuxPhp\Models\UpdateAssetRequest::__construct(): Implicitly marking parameter $data as nullable is deprecated, the explicit nullable type must be used instead in /code/vendor/muxinc/mux-php/MuxPhp/Models/UpdateAssetRequest.php on line 244

Affected Classes
• MuxPhp\Models\UpdateAssetRequest
• MuxPhp\Models\Asset
• MuxPhp\Models\AssetResponse
• MuxPhp\Models\AssetsApi
• MuxPhp\Models\PlaybackID
• MuxPhp\Models\AssetNonStandardInputReasons
• Likely more, across the SDK

[yoannblot]

In order to fix this we should replace all the constructor types.

Example of what we should do in AssetsApi https://github.com/muxinc/mux-php/blob/master/MuxPhp/Api/AssetsApi.php#L78-L82

replace:

public function __construct(
    ClientInterface $client = null,
    Configuration $config = null,
    HeaderSelector $selector = null,
    $hostIndex = 0
) {

with:

public function __construct(
    ?ClientInterface $client = null,
    ?Configuration $config = null,
    ?HeaderSelector $selector = null,
    int $hostIndex = 0
) {

I tried to create a PR but I don't have permission to do it...

[yoannblot]

@eropple @jsanford8 how can I propose a PR?

[philcluff]

Hey @yoannblot, we're currently working on a full replacement for this SDK - I would recommend waiting for that replacement to land. Thank you.

[tim-hanssen]

Hey @philcluff any timeline for that? Otherwise we will going to replace it with something custom build,

[Alex131997]

Hi @philcluff @jsanford8
Could you please let me know when we can expect this bug to be fixed or the new SDK to be released?