From dcf231371c5cd3a7518d5c1d42f3a12d6a73eebd Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 5 Sep 2025 15:01:58 +0200 Subject: [PATCH 1/3] Bump miminum RuboCop dependency versions --- ghtml2pdf.gemspec | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ghtml2pdf.gemspec b/ghtml2pdf.gemspec index d536e2e..ee95f3c 100644 --- a/ghtml2pdf.gemspec +++ b/ghtml2pdf.gemspec @@ -36,8 +36,8 @@ Gem::Specification.new do |spec| spec.add_development_dependency "rake", "~> 13.0" spec.add_development_dependency "rake-manifest", "~> 0.2.0" spec.add_development_dependency "rspec", "~> 3.3" - spec.add_development_dependency "rubocop", "~> 1.56" + spec.add_development_dependency "rubocop", "~> 1.80" spec.add_development_dependency "rubocop-packaging", "~> 0.6.0" - spec.add_development_dependency "rubocop-performance", "~> 1.19" - spec.add_development_dependency "rubocop-rspec", "~> 3.0" + spec.add_development_dependency "rubocop-performance", "~> 1.25" + spec.add_development_dependency "rubocop-rspec", "~> 3.7" end From b268502f1e3ce370de6d9b1ac17fbf5f4748628c Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 5 Sep 2025 15:02:29 +0200 Subject: [PATCH 2/3] Use the new rubocop plugins configuration syntax --- .rubocop.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index 999dab4..705e93c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,4 +1,4 @@ -require: +plugins: - rubocop-packaging - rubocop-performance - rubocop-rspec From 439ee2b1c0b7fec8b76d811c92f77963c0a7cc9d Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Fri, 5 Sep 2025 15:03:22 +0200 Subject: [PATCH 3/3] Fix Style/ItAssignment offense --- lib/ghtml2pdf/application.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ghtml2pdf/application.rb b/lib/ghtml2pdf/application.rb index 4b764a6..ad13c91 100644 --- a/lib/ghtml2pdf/application.rb +++ b/lib/ghtml2pdf/application.rb @@ -105,7 +105,7 @@ def web_view end def print_settings - @print_settings ||= PrintSettings.new.tap { |it| it.output_uri = output_uri } + @print_settings ||= PrintSettings.new.tap { _1.output_uri = output_uri } end def output_uri