Skip to content

Conversation

@fmmoret
Copy link
Contributor

@fmmoret fmmoret commented Nov 26, 2025

Is this all that's needed?

@mxmlnkn
Copy link
Owner

mxmlnkn commented Nov 26, 2025

Is this all that's needed?

I think so, yes. Thanks for your work!

@mxmlnkn
Copy link
Owner

mxmlnkn commented Nov 26, 2025

The pyproject.toml in the librapidarchive should also add the 3.14 specifier, and then the submodule pinning needs to change. And then, I'll probably have to backport this and the fixes to a new 0.15.2 and trigger an updated release.

@mxmlnkn mxmlnkn merged commit 67ce010 into mxmlnkn:main Nov 30, 2025
18 checks passed
@fmmoret
Copy link
Contributor Author

fmmoret commented Nov 30, 2025

Thanks for merging / doing the last chores. I would have helped with some more tomorrow but wrapping up Thanksgiving stuff w/ visiting fam this weekend

@mxmlnkn
Copy link
Owner

mxmlnkn commented Nov 30, 2025

No problem. But I think I have dug myself a bit of a hole with trying to make librapidarchive a submodule instead of a low-weight fork ... And the Windows CI suddenly seems to have an issue with building :(

@fmmoret
Copy link
Contributor Author

fmmoret commented Nov 30, 2025

Dug around on my phone a bit. May be more issues but i think this line needs a bump from 4 to 5

CIBW_SKIP: "*cp31[4-9]*"

@mxmlnkn
Copy link
Owner

mxmlnkn commented Nov 30, 2025

Dug around on my phone a bit. May be more issues but i think this line needs a bump from 4 to 5

CIBW_SKIP: "*cp31[4-9]*"

This was indeed an issue, but a different one. I set it to CIBW_SKIP: "*cp3??t-win*". See also pypa/cibuildwheel#2676 .

The Windows issue seems to have been some weird issue with conda, which I only used to install pigz for the tests. The solution was to install conda and pigz after building the static binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants