simplify API of reset

Implement simplification per requested at
#945 (comment)

Author: tlindi

rootfs/standard/var/pynode/application_info.py

@@ -760,35 +760,30 @@ def backup_data_folder(app_data):
 def restore_data_folder(app_data):
     log_message("  Running restore_data_folder...")
 
-def reset_data_folder(app_data):
-    log_message("  Running reset_data_folder...")
-
-    # If app_data is a string (short name), convert it to a full configuration
-    # and preserve the original short name.
-    if isinstance(app_data, str):
-        original_short_name = app_data  # Save the short name for service commands.
-        app_data = get_application(app_data)
-    else:
-        original_short_name = app_data["short_name"]
-
+def reset_data_folder(short_name):
+    log_message(f"  Running reset_data_folder for '{short_name}'...")
+    
+    app_data = get_application(short_name)
+    if not app_data:
+        log_message(f"  ERROR: application '{short_name}' not found")
+         return False
     data_folder = app_data["storage_folder"]
 
     # Stop the service before removing data_folder
-    log_message("Stopping '{}'.".format(original_short_name))
-    stop_service(original_short_name)
+    log_message(f"  Stopping '{short_name}'…")
+    stop_service(short_name)
 
     # Remove App data_folder
-    log_message("Removing storage folder '{}' of '{}'...".format(data_folder, original_short_name))
-    data_folder = app_data["storage_folder"]
-    run_linux_cmd("rm -rf {}".format(data_folder))
+    log_message(f"  Removing storage folder '{data_folder}'…")
+    run_linux_cmd(f"rm -rf {data_folder}")
 
     # Re-create the storage folder
-    log_message("Creating storage folder '{}' of '{}'...".format(data_folder, original_short_name))
+    log_message(f"  Creating storage folder '{data_folder}'…")
     create_application_storage_folder(app_data)
 
     # Re-start the service
-    log_message("Starting '{}'.".format(original_short_name))
-    start_service(original_short_name)
+    log_message(f"  Starting '{short_name}'…")
+    start_service(short_name)
 
     return True
 

rootfs/standard/var/www/mynode/api.py

@@ -149,43 +149,42 @@ def api_restart_app():
 
     return "OK"
 
-#    @mynode_api.route("/api/restart_app")
 @mynode_api.route("/api/backup_data_folder")
 def api_backup_data_folder():
     check_logged_in()
 
-    app = request.args.get("app")
-    if not app:
+    short_name = request.args.get("short_name")
+    if not short_name:
         return "NO_APP_SPECIFIED"
-    if not is_application_valid(app):
+    if not is_application_valid(short_name):
         return "INVALID_APP_NAME"
-    if not backup_data_folder(app):
+    if not backup_data_folder(short_name):
         return "ERROR"
     return "OK"
 
 @mynode_api.route("/api/restore_data_folder")
 def api_restore_data_folder():
     check_logged_in()
 
-    app = request.args.get("app")
-    if not app:
+    short_name = request.args.get("short_name")
+    if not short_name:
         return "NO_APP_SPECIFIED"
-    if not is_application_valid(app):
+    if not is_application_valid(short_name):
         return "INVALID_APP_NAME"
-    if not restore_data_folder(app):
+    if not restore_data_folder(short_name):
         return "ERROR"
     return "OK"
 
 @mynode_api.route("/api/reset_data_folder")
 def api_reset_data_folder():
     check_logged_in()
 
-    app = request.args.get("app")
-    if not app:
+    short_name = request.args.get("short_name")
+    if not short_name:
         return "NO_APP_SPECIFIED"
-    if not is_application_valid(app):
+    if not is_application_valid(short_name):
         return "INVALID_APP_NAME"
-    if not reset_data_folder(app):
+    if not reset_data_folder(short_name):
         return "ERROR"
     return "OK"