Skip to content

STATEMIND-173: Redundant option to set allowAllPairs to false #587

@asardon

Description

@asardon

Description

Within the setGlobalPolicy() function, there exists an option to set the global policy with the allowAllPairs parameter set to false. However, considering the flow of the isAllowed() function, if globalPolicy.allowAllPairs is false:

When a pairPolicy is present, it takes precedence.
When no pairPolicy is present, a given quote is disallowed.
Consequently, the utilization of globalPolicy becomes obsolete when allowAllPairs is set to false.

Recommendation

It is recommended to conduct a review of the globalPolicy workflow, followed by appropriate adjustments. For instance, consider removing the allowAllPairs parameter from globalPolicy.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions