Description
If tenor is zero and quote is a swap, then quoteTuple.upfrontFeePctInBase == Constants.BASE based on QuoteHandler.sol#L591. Then the check at the line BasicQuotePolicyManager.sol#L299 is unnecessary.
Recommendation
We recommend to move the if statement at line BasicQuotePolicyManager.sol#L299 inside the if at line BasicQuotePolicyManager.sol#L283.