Skip to content

STATEMIND-175: Unnecessary check if quote is swap #589

@asardon

Description

@asardon

Description

If tenor is zero and quote is a swap, then quoteTuple.upfrontFeePctInBase == Constants.BASE based on QuoteHandler.sol#L591. Then the check at the line BasicQuotePolicyManager.sol#L299 is unnecessary.

Recommendation

We recommend to move the if statement at line BasicQuotePolicyManager.sol#L299 inside the if at line BasicQuotePolicyManager.sol#L283.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions