Skip to content

STATEMIND-176: Inadequate checks for quoteBounds #590

@asardon

Description

@asardon

Description

The quoteBounds parameters minLoanPerCollUnitOrLtv and maxLoanPerCollUnitOrLtv can be set to 0. quoteTuple with loanPerCollUnitOrLtv == 0 is not allowed at the line QuoteHandler.sol#L560.
The quoteBounds.minFee checks the min value that quoteTuple.upfrontFeePctInBase can be, but quoteBounds.minFee can be set to a bigger value than Constants.BASE which is the max value for quoteTuple.upfrontFeePctInBase (QuoteHandler.sol#L541-L558).

Recommendation

We recommend to add more checks for quoteBounds.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions