Skip to content

PingMessage is not being correctly handled for NumPongBytes > 65531 #87

@nGoline

Description

@nGoline

If a peer sends a PingMessage asking for num_pong_bytes >= 65532 bytes, their intent is that we ignore the ping, as per BOLT1's spec:

A node receiving a ping message:

- if num_pong_bytes is less than 65532:
    - MUST respond by sending a pong message, with byteslen equal to num_pong_bytes.
- otherwise (num_pong_bytes is not less than 65532):
    - MUST ignore the ping.

We're not implement this, causing Core Lightning nodes to crash upon connection.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions