fix: no duplicate address options and make sure alias matches for cus… (#2323)

Author: neocybereth

apps/namadillo/src/App/Transfer/DestinationAddressModal.tsx

@@ -107,10 +107,12 @@ export const DestinationAddressModal = ({
         : getChainImageUrl(getChainFromAddress(keplrAddress ?? "")),
       type: "keplr",
     });
+  const addressOptionsAddresses = addressOptions.map((addr) => addr.address);
 
   // Build recent addresses options
-  const recentAddressOptions: AddressOption[] = recentAddresses.map(
-    (recent) => ({
+  const recentAddressOptions: AddressOption[] = recentAddresses
+    .filter((addresses) => !addressOptionsAddresses.includes(addresses.address))
+    .map((recent) => ({
       id: `recent-${recent.address}`,
       label: recent.label || getAddressLabel(recent.address, recent.type),
       address: recent.address,
@@ -119,8 +121,7 @@ export const DestinationAddressModal = ({
         : recent.type === "transparent" ? namadaTransparentIcon
         : getChainImageUrl(getChainFromAddress(recent.address ?? "")), // fallback for IBC
       type: recent.type,
-    })
-  );
+    }));
 
   const validateAddress = (address: string): ValidationResult => {
     // Check if address is empty

apps/namadillo/src/App/Transfer/TransferDestination.tsx

@@ -138,6 +138,16 @@ export const TransferDestination = ({
     : isTransparentAddress(destinationAddress ?? "") ? "transparent"
     : "ibc";
 
+  const getDestinationAddressLabel = (): string => {
+    if (!destinationAddress) return "";
+    if (isIbcAddress(destinationAddress ?? "")) return "Keplr";
+    const shieldedAddress = shieldedAccount?.address;
+    const transparentAddress = transparentAccount?.address;
+    if ([shieldedAddress, transparentAddress].includes(destinationAddress))
+      return alias ?? "";
+    return "Custom";
+  };
+
   return (
     <>
       <div
@@ -216,7 +226,7 @@ export const TransferDestination = ({
                     <div className="flex flex-col ml-4">
                       <div className="flex flex-col">
                         <span className="text-neutral-500 text-left font-normal text-xs">
-                          {isIbcAddress(destinationAddress) ? "Keplr" : alias}
+                          {getDestinationAddressLabel()}
                         </span>
                         <span className="text-white text-sm font-normal">
                           {shortenAddress(destinationAddress, 15, 15)}