-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Open
Copy link
Description
Background
- See Return beautified display names #1501. That issue is a prerequisite for the ideas discussed here.
- Reference docs about the
displayrecord in the following ENSIP: https://docs.ens.domains/ensip/5/
Goals
- Fully optimize the value we return for
displayName. - Provide yet another advantage we can cite for why use of ENSNode is the best solution for building on ENS.
Requirements
- During a primary name lookup, when fetching the forward resolution address of the reverse name, also fetch the
displaytext record. - If a primary name lookup fails, nothing changes, and any
displaytext record that might have been found is ignored. - If a primary name lookup succeeds:
- If no
displayrecord is defined: nothing changes with our logic. - If a
displayrecord is defined, andnormalize(display)!== the primary name: nothing changes with our logic and thedisplaytext record is ignored. - Else: return the
displayrecord as thedisplayNamefield.
- If no
- Advice appreciated: Does the additional lookup of the
displaytext record meaningfully impact latency? If so, maybe we make it so that the use of this feature is only activated conditionally based on a param attached to the API request?
Metadata
Metadata
Assignees
Labels
ensapiENSApi relatedENSApi related
Type
Projects
Status
Todo