Merge pull request #13 from nameko/truncate-data-params

Truncate request.data payload as it can get big

Author: samantharosa

nameko_opentelemetry/http.py

@@ -74,8 +74,15 @@ def get_attributes(self, worker_ctx):
             )
 
         if self.config.get("send_request_payloads"):
+            response, truncated = utils.truncate(
+                utils.serialise_to_string(scrub(data, self.config)),
+                max_len=self.config.get("truncate_max_length"),
+            )
             attributes.update(
-                {"request.data": utils.serialise_to_string(scrub(data, self.config))}
+                {
+                    "request.data": response,
+                    "request.data_truncated": str(truncated),
+                }
             )
 
         return attributes

nameko_opentelemetry/version.py

@@ -1,2 +1,2 @@
 # -*- coding: utf-8 -*-
-__version__ = "0.5.0"
+__version__ = "0.5.1"

tests/test_http.py

@@ -195,6 +195,8 @@ def config(self, config, send_headers, send_request_payloads):
         config["send_headers"] = send_headers
         # disable request payload based on param
         config["send_request_payloads"] = send_request_payloads
+        # override default truncation length
+        config["truncate_max_length"] = 100
         return config
 
     @pytest.fixture
@@ -244,6 +246,24 @@ def test_request_data(
         else:
             assert "request.data" not in attributes
 
+    def test_request_data_truncated(
+        self, container, web_session, memory_exporter, send_request_payloads
+    ):
+        with entrypoint_waiter(container, "get_resource"):
+            resp = web_session.get("/resource", data="A" * 200)
+
+        assert resp.status_code == 200
+
+        spans = memory_exporter.get_finished_spans()
+        assert len(spans) == 1
+
+        attributes = spans[0].attributes
+
+        if send_request_payloads:
+            assert attributes["request.data"] == "A" * 100
+        else:
+            assert "request.data" not in attributes
+
     def test_request_headers(
         self, container, web_session, memory_exporter, send_headers
     ):