GQL-113: Addresses PR feedback

Author: dmistry1

src/cmr/concepts/citation.js

@@ -23,18 +23,18 @@ export default class Citation extends Concept {
   getPermittedJsonSearchParams() {
     return [
       ...super.getPermittedJsonSearchParams(),
-      'author-name',
-      'author-orcid',
+      'author_name',
+      'author_orcid',
       'container',
-      'identifier-type',
+      'identifier_type',
       'identifier',
       'keyword',
       'name',
-      'native-id',
+      'native_id',
       'provider',
-      'related-identifier',
-      'relationship-type',
-      'resolution-authority',
+      'related_identifier',
+      'relationship_type',
+      'resolution_authority',
       'title',
       'type',
       'year'
@@ -47,18 +47,18 @@ export default class Citation extends Concept {
   getPermittedUmmSearchParams() {
     return [
       ...super.getPermittedUmmSearchParams(),
-      'author-name',
-      'author-orcid',
+      'author_name',
+      'author_orcid',
       'container',
-      'identifier-type',
+      'identifier_type',
       'identifier',
       'keyword',
       'name',
-      'native-id',
+      'native_id',
       'provider',
-      'related-identifier',
-      'relationship-type',
-      'resolution-authority',
+      'related_identifier',
+      'relationship_type',
+      'resolution_authority',
       'title',
       'type',
       'year'

src/resolvers/__tests__/citation.test.js

@@ -180,7 +180,6 @@ describe('Citation', () => {
       })
 
       const { data, errors } = response.body.singleResult
-      console.log('🚀 ~ test ~ errors:', errors)
 
       expect(errors).toBeUndefined()