Skip to content

Commit 94ebe11

Browse files
cvietorcvietor
committed
fix: npm script paths corrected, removed obsolete test scripts. reset scripts use ns clean. fixed readme
removed hardcoded DEVELOPMENT_TEAM id from demo's build.xcconfig
1 parent 3040494 commit 94ebe11

File tree

3 files changed

+127
-130
lines changed

3 files changed

+127
-130
lines changed

‎README.md‎

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ You will also need to set up your development environment. Please refer to the [
4848
# Installation
4949

5050
```
51-
$ tns plugin install @nativescript-community/ui-mapbox
51+
$ ns plugin install @nativescript-community/ui-mapbox
5252
```
5353

5454
# DEMOS
@@ -63,22 +63,25 @@ The style can be set to one of the Mapbox style names or it can be the URL of yo
6363

6464
> NOTE: As of this writing, the NativeScript demo only works with a mapbox token. The demo-angular will work with either a self hosted tile server or a mapbox token.
6565
66+
## Demo prerequisites
67+
```
68+
npm run setup
69+
```
70+
71+
6672
## To run the Angular demo
6773

6874
```
69-
cd src
70-
npm run build.release
71-
cd ../demo-angular
72-
tns run <platform>
75+
npm run build
76+
cd ./demo-angular
77+
ns run <platform>
7378
```
7479

7580
## To run the plain Nativescript demo
76-
7781
```
78-
cd src
79-
npm run build.release
80-
cd ../demo
81-
tns run <platform>
82+
npm run build
83+
cd ./demo
84+
ns run <platform>
8285
```
8386

8487
## Debug Build
@@ -96,7 +99,7 @@ sharing of mapping code between browser based and native applications.
9699
## Issues
97100

98101
If you get an error during iOS build related to Podspec versions, probably the easiest fix is:
99-
`tns platform remove ios` and `tns platform add ios`.
102+
`ns platform remove ios` and `ns platform add ios`.
100103

101104
On Android the plugin adds this to the `<application>` node of `app/App_Resources/Android/AndroidManifest.xml` (the plugin already attempts to do so):
102105

‎demo/app/App_Resources/iOS/build.xcconfig‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,4 @@
22
// for example you can uncomment the following line to force distribution code signing
33
// CODE_SIGN_IDENTITY = iPhone Distribution
44
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
5-
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;
6-
7-
DEVELOPMENT_TEAM = 8Q5F6M3TNS
5+
ASSETCATALOG_COMPILER_LAUNCHIMAGE_NAME = LaunchImage;

‎package.json‎

Lines changed: 112 additions & 116 deletions
Original file line numberDiff line numberDiff line change
@@ -1,121 +1,117 @@
11
{
2-
"name": "@nativescript-community/ui-mapbox",
3-
"version": "5.0.0",
4-
"description": "A Nativescript plugin for Mapbox Native Maps.",
5-
"nativescript": {
6-
"platforms": {
7-
"android": "3.0.0",
8-
"ios": "3.0.0"
2+
"name": "@nativescript-community/ui-mapbox",
3+
"version": "5.0.0",
4+
"description": "A Nativescript plugin for Mapbox Native Maps.",
5+
"nativescript": {
6+
"platforms": {
7+
"android": "3.0.0",
8+
"ios": "3.0.0"
9+
},
10+
"plugin": {
11+
"nan": true,
12+
"pan": true,
13+
"core3": "true",
14+
"category": "Interface"
15+
}
916
},
10-
"plugin": {
11-
"nan": true,
12-
"pan": true,
13-
"core3": "true",
14-
"category": "Interface"
15-
}
16-
},
17-
"scripts": {
18-
"setup": "ts-patch install",
19-
"build.angular": "ng-packagr -p src/angular/package.json -c src/angular/tsconfig.json",
20-
"clean": "rimraf ./plugin/**/*.d.ts ./plugin/**/*.js ./plugin/**/*.js.map plugin/node_modules plugin/package-lock.json plugin/README.md demo/node_modules demo-angular/node_modules",
21-
"tsc": "cpy '**/*.d.ts' '../plugin' --parents --cwd=src && tsc -skipLibCheck -d",
22-
"build": "cp README.md ./plugin && rm -f .tsbuildinfo && npm run tsc ",
23-
"publish": "npm run setup && npm run build && lerna publish --create-release=github",
24-
"commitmsg": "commitlint -e $GIT_PARAMS",
25-
"demo.ios": "npm run build && cd ../demo && tns run ios --syncAllFiles",
26-
"demo.android": "npm run build && cd ../demo && tns run android",
27-
"demo.android.build": "npm run build && cd ../demo && tns build android --log debug",
28-
"test": "npm run tslint && npm run tslint.demo && cd ../demo && tns build ios && tns build android",
29-
"test.ios": "cd ../demo && tns test ios --emulator --justlaunch",
30-
"test.ios.device": "cd ../demo && tns test ios",
31-
"test.android": "cd ../demo && tns test android --justlaunch",
32-
"eslint": "eslint 'src/**/*.ts' --fix",
33-
"prepublishOnly": "npm run build",
34-
"generate.typings.ios": "cd ../demo && TNS_DEBUG_METADATA_PATH=\"$(pwd)/metadata\" tns build ios && TNS_TYPESCRIPT_DECLARATIONS_PATH=\"$(pwd)/typings\" tns build ios && echo 'Now look for your library typings in demo/typings!'",
35-
"demo-angular.reset": "cd ../demo-angular && npx rimraf -- hooks node_modules platforms package-lock.json",
36-
"demo.reset": "cd ../demo && npx rimraf -- hooks node_modules platforms package-lock.json"
37-
},
38-
"repository": {
39-
"type": "git",
40-
"url": "https://github.com/nativescript-community/ui-mapbox.git"
41-
},
42-
"keywords": [
43-
"ecosystem:nativescript",
44-
"NativeScript",
45-
"Map",
46-
"Maps",
47-
"Native Maps",
48-
"Mapbox"
49-
],
50-
"author": {
51-
"name": "Yermo Lamers",
52-
"email": "yml@yml.com",
53-
"url": "https://miles-by-motorcycle.com/flyingbricksoftware/about"
54-
},
55-
"contributors": [
56-
{
57-
"name": "Eddy Verbruggen - Original Author",
58-
"email": "eddyverbruggen@gmail.com"
17+
"scripts": {
18+
"setup": "npm i && ts-patch install",
19+
"build.angular": "ng-packagr -p src/angular/package.json -c src/angular/tsconfig.json",
20+
"clean": "rimraf ./plugin/**/*.d.ts ./plugin/**/*.js ./plugin/**/*.js.map plugin/node_modules plugin/package-lock.json plugin/README.md demo/node_modules demo-angular/node_modules",
21+
"tsc": "cpy '**/*.d.ts' '../plugin' --parents --cwd=src && tsc -skipLibCheck -d",
22+
"build": "cp README.md ./plugin && rm -f .tsbuildinfo && npm run tsc ",
23+
"publish": "npm run setup && npm run build && lerna publish --create-release=github",
24+
"commitmsg": "commitlint -e $GIT_PARAMS",
25+
"demo.ios": "npm run build && cd ./demo && ns run ios",
26+
"demo.android": "npm run build && cd ./demo && ns run android",
27+
"demo.android.build": "npm run build && cd ./demo && ns build android --log debug",
28+
"eslint": "eslint 'src/**/*.ts' --fix",
29+
"prepublishOnly": "npm run build",
30+
"generate.typings.ios": "cd ./demo && TNS_DEBUG_METADATA_PATH=\"$(pwd)/metadata\" ns build ios && TNS_TYPESCRIPT_DECLARATIONS_PATH=\"$(pwd)/typings\" ns build ios && echo 'Now look for your library typings in demo/typings!'",
31+
"demo-angular.reset": "cd ./demo-angular && ns clean",
32+
"demo.reset": "cd ./demo && ns clean"
33+
},
34+
"repository": {
35+
"type": "git",
36+
"url": "https://github.com/nativescript-community/ui-mapbox.git"
37+
},
38+
"keywords": [
39+
"ecosystem:nativescript",
40+
"NativeScript",
41+
"Map",
42+
"Maps",
43+
"Native Maps",
44+
"Mapbox"
45+
],
46+
"author": {
47+
"name": "Yermo Lamers",
48+
"email": "yml@yml.com",
49+
"url": "https://miles-by-motorcycle.com/flyingbricksoftware/about"
50+
},
51+
"contributors": [
52+
{
53+
"name": "Eddy Verbruggen - Original Author",
54+
"email": "eddyverbruggen@gmail.com"
55+
},
56+
{
57+
"name": "Alex Wells",
58+
"email": "autaut03@gmail.com"
59+
}
60+
],
61+
"license": "MIT",
62+
"bugs": {
63+
"url": "https://github.com/nativescript-community/ui-mapbox/issues"
64+
},
65+
"homepage": "https://github.com/nativescript-community/ui-mapbox",
66+
"readmeFilename": "README.md",
67+
"devDependencies": {
68+
"@angular/animations": "~10.1.5",
69+
"@angular/common": "~10.1.5",
70+
"@angular/compiler": "~10.1.5",
71+
"@angular/compiler-cli": "~10.1.5",
72+
"@angular/core": "~10.1.5",
73+
"@angular/forms": "~10.1.5",
74+
"@angular/platform-browser": "~10.1.5",
75+
"@angular/platform-browser-dynamic": "11.0.0-rc.3",
76+
"@angular/router": "~10.1.5",
77+
"@commitlint/cli": "^11.0.0",
78+
"@commitlint/config-conventional": "^11.0.0",
79+
"@nativescript-community/perms": "^2.1.1",
80+
"@nativescript/angular": "10.1.7",
81+
"@nativescript/core": "7.0.13",
82+
"@nativescript/ios": "7.0.5",
83+
"@nativescript/types-android": "~7.0.4",
84+
"@nativescript/types-ios": "~7.0.4",
85+
"@nativescript/webpack": "3.0.8",
86+
"@types/node": "14.14.7",
87+
"@types/react": "16.9.56",
88+
"@typescript-eslint/eslint-plugin": "4.7.0",
89+
"@typescript-eslint/parser": "4.7.0",
90+
"cpy-cli": "^3.1.1",
91+
"eslint": "7.13.0",
92+
"eslint-config-prettier": "^6.15.0",
93+
"eslint-plugin-prettier": "^3.1.4",
94+
"husky": "^4.3.0",
95+
"lerna": "^3.22.1",
96+
"ng-packagr": "~10.1.2",
97+
"prettier": "^2.1.2",
98+
"prompt": "^1.0.0",
99+
"react-nativescript": "^2.1.0",
100+
"rimraf": "^3.0.2",
101+
"rxjs": "^6.6.3",
102+
"svelte-native": "0.9.5",
103+
"ts-patch": "^1.3.0",
104+
"tslib": "2.0.3",
105+
"typescript": "3.9.7",
106+
"zone.js": "0.11.3",
107+
"vue": "^2.6.12"
108+
},
109+
"dependencies": {
110+
"ts-node": "^9.0.0"
59111
},
60-
{
61-
"name": "Alex Wells",
62-
"email": "autaut03@gmail.com"
112+
"commitlint": {
113+
"extends": [
114+
"@commitlint/config-conventional"
115+
]
63116
}
64-
],
65-
"license": "MIT",
66-
"bugs": {
67-
"url": "https://github.com/nativescript-community/ui-mapbox/issues"
68-
},
69-
"homepage": "https://github.com/nativescript-community/ui-mapbox",
70-
"readmeFilename": "README.md",
71-
"devDependencies": {
72-
"@angular/animations": "~10.1.5",
73-
"@angular/common": "~10.1.5",
74-
"@angular/compiler": "~10.1.5",
75-
"@angular/compiler-cli": "~10.1.5",
76-
"@angular/core": "~10.1.5",
77-
"@angular/forms": "~10.1.5",
78-
"@angular/platform-browser": "~10.1.5",
79-
"@angular/platform-browser-dynamic": "11.0.0-rc.3",
80-
"@angular/router": "~10.1.5",
81-
"@commitlint/cli": "^11.0.0",
82-
"@commitlint/config-conventional": "^11.0.0",
83-
"@nativescript-community/perms": "^2.1.1",
84-
"@nativescript/angular": "10.1.7",
85-
"@nativescript/core": "7.0.13",
86-
"@nativescript/ios": "7.0.5",
87-
"@nativescript/types-android": "~7.0.4",
88-
"@nativescript/types-ios": "~7.0.4",
89-
"@nativescript/webpack": "3.0.8",
90-
"@types/node": "14.14.7",
91-
"@types/react": "16.9.56",
92-
"@typescript-eslint/eslint-plugin": "4.7.0",
93-
"@typescript-eslint/parser": "4.7.0",
94-
"cpy-cli": "^3.1.1",
95-
"eslint": "7.13.0",
96-
"eslint-config-prettier": "^6.15.0",
97-
"eslint-plugin-prettier": "^3.1.4",
98-
"husky": "^4.3.0",
99-
"lerna": "^3.22.1",
100-
"ng-packagr": "~10.1.2",
101-
"prettier": "^2.1.2",
102-
"prompt": "^1.0.0",
103-
"react-nativescript": "^2.1.0",
104-
"rimraf": "^3.0.2",
105-
"rxjs": "^6.6.3",
106-
"svelte-native": "0.9.5",
107-
"ts-patch": "^1.3.0",
108-
"tslib": "2.0.3",
109-
"typescript": "3.9.7",
110-
"zone.js": "0.11.3",
111-
"vue": "^2.6.12"
112-
},
113-
"dependencies": {
114-
"ts-node": "^9.0.0"
115-
},
116-
"commitlint": {
117-
"extends": [
118-
"@commitlint/config-conventional"
119-
]
120-
}
121117
}

0 commit comments

Comments
 (0)