Skip to content

Commit c7f0f08

Browse files
committed
fixed tests for uniqueness hash
1 parent 9ac7924 commit c7f0f08

File tree

2 files changed

+28
-2
lines changed

2 files changed

+28
-2
lines changed

gsrs-module-substance-example/src/test/java/example/substance/validation/SaltValidatorTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import java.io.File;
2626
import java.io.IOException;
2727
import java.util.List;
28+
import java.util.UUID;
29+
2830
import lombok.extern.slf4j.Slf4j;
2931
import org.junit.After;
3032
import org.junit.AfterClass;
@@ -114,6 +116,8 @@ public void testFindLayer1DefHashDuplicates() {
114116
log.trace("testFindLayer1DefHashDuplicates");
115117
String approvalID = "660YQ98I10";
116118
ChemicalSubstance chemical = getChemicalFromFile(approvalID);
119+
chemical.uuid=UUID.randomUUID();
120+
117121
List<Substance> duplicates = ValidationUtils.findDefinitionaLayer1lDuplicateCandidates(chemical,
118122
new DefHashCalcRequirements(definitionalElementFactory, searchService, transactionManager) );
119123
log.trace("duplicate list size: " + duplicates.size() + "; items: ");
@@ -133,6 +137,8 @@ public void testFindFullDefHashDuplicates() {
133137
log.trace("TestFindFullDefHashDuplicates");
134138
String approvalID = "660YQ98I10";
135139
ChemicalSubstance chemical = getChemicalFromFile(approvalID);
140+
chemical.uuid=UUID.randomUUID();
141+
136142
List<Substance> duplicates = ValidationUtils.findFullDefinitionalDuplicateCandidates(chemical,
137143
new DefHashCalcRequirements( definitionalElementFactory, searchService, transactionManager));
138144
assertEquals(1, duplicates.size());

gsrs-module-substance-example/src/test/java/example/substance/validation/SubstanceUniquenessValidatorTest.java

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
import ix.ginas.utils.validation.validators.SubstanceUniquenessValidator;
2020
import java.io.File;
2121
import java.io.IOException;
22+
import java.util.UUID;
23+
2224
import lombok.extern.slf4j.Slf4j;
2325
import org.junit.jupiter.api.Assertions;
2426
import org.junit.jupiter.api.BeforeEach;
@@ -75,6 +77,7 @@ public void testValidation() {
7577
String name ="G6867RWN6N";
7678
String completeDuplicateMessage= "appears to be a full duplicate";
7779
ChemicalSubstance protein = getChemicalSubstanceFromFile(name);
80+
protein.uuid= UUID.randomUUID();
7881
SubstanceUniquenessValidator validator = new SubstanceUniquenessValidator();
7982
AutowireHelper.getInstance().autowire(validator);
8083
ValidationResponse response = validator.validate(protein, null);
@@ -87,6 +90,8 @@ public void testExactDuplicateStrDiv() {
8790
String name ="N5WWR36MDJ";
8891
String completeDuplicateMessage= "appears to be a full duplicate";
8992
Substance substance = getSubstanceFromFile(name);
93+
substance.uuid= UUID.randomUUID();
94+
9095
SubstanceUniquenessValidator validator = new SubstanceUniquenessValidator();
9196
AutowireHelper.getInstance().autowire(validator);
9297
ValidationResponse response = validator.validate(substance, null);
@@ -97,12 +102,27 @@ public void testValidationDiastereomer() {
97102
log.trace("Starting in testValidation");
98103
String name ="G6867RWN6N-diast";
99104
String possibleDuplicateMessage= "is a possible duplicate";
100-
ChemicalSubstance protein = getChemicalSubstanceFromFile(name);
105+
ChemicalSubstance chem = getChemicalSubstanceFromFile(name);
106+
chem.uuid=UUID.randomUUID();
107+
101108
SubstanceUniquenessValidator validator = new SubstanceUniquenessValidator();
102109
AutowireHelper.getInstance().autowire(validator);
103-
ValidationResponse response = validator.validate(protein, null);
110+
ValidationResponse response = validator.validate(chem, null);
104111
Assertions.assertTrue(response.getValidationMessages().stream().anyMatch(m-> ((GinasProcessingMessage) m).message.contains(possibleDuplicateMessage)));
105112
}
113+
114+
@Test
115+
public void testDuplicateDoesNotFindItself() {
116+
log.trace("Starting in testValidation");
117+
String name ="G6867RWN6N-diast";
118+
String possibleDuplicateMessage= "is a possible duplicate";
119+
ChemicalSubstance chem = getChemicalSubstanceFromFile(name);
120+
SubstanceUniquenessValidator validator = new SubstanceUniquenessValidator();
121+
AutowireHelper.getInstance().autowire(validator);
122+
ValidationResponse response = validator.validate(chem, null);
123+
//should not contain a duplicate message
124+
Assertions.assertFalse(response.getValidationMessages().stream().anyMatch(m-> ((GinasProcessingMessage) m).message.contains(possibleDuplicateMessage)));
125+
}
106126

107127
@Test
108128
public void testValidationNoDuplicates() {

0 commit comments

Comments
 (0)